Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull in MANE preferred transcript from the allele registry #550

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from
Open

Pull in MANE preferred transcript from the allele registry #550

wants to merge 2 commits into from

Conversation

susannasiebert
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Nov 5, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 2103

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 89.524%
Changes Missing Coverage Covered Lines Changed/Added Lines %
app/controllers/variants_controller.rb 3 4 75.0%
Totals Coverage Status
Change from base Build 2095: -0.04%
Covered Lines: 1957
Relevant Lines: 2186
💛 - Coveralls

acoffman
acoffman approved these changes Nov 5, 2019
View reviewed changes
Copy link
Member

@acoffman acoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nitpick but overall looks good!

app/models/mane_preferred_transcript.rb Outdated Show resolved Hide resolved
app/models/mane_preferred_transcript.rb Show resolved Hide resolved
@susannasiebert susannasiebert mentioned this pull request Apr 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acoffman acoffman acoffman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@susannasiebert @coveralls @acoffman