Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

195 switch project to uv #197

Merged
merged 5 commits into from
Mar 8, 2025
Merged

195 switch project to uv #197

merged 5 commits into from
Mar 8, 2025

Conversation

grillazz
Copy link
Owner

@grillazz grillazz commented Mar 8, 2025

No description provided.

@grillazz grillazz requested a review from Copilot March 8, 2025 16:59
@grillazz grillazz self-assigned this Mar 8, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This pull request switches the project to use uv as the runtime tool and cleans up import orders across multiple modules.

  • Added a linting step using "uv run --frozen ruff check ." to the CI workflow.
  • Reordered and de-duplicated import statements in various files for consistency.
  • Made minor adjustments to import order in configuration and API routing modules.

Reviewed Changes

File Description
.github/workflows/build-and-test.yml Added a linting step using uv run with ruff.
app/main.py Reorganized import statements and removed duplicates.
app/schemas/stuff.py Adjusted import order from pydantic.
app/api/nonsense.py Reordered imports for clarity.
app/schemas/nnonsense.py Adjusted import order; consider verifying the filename.
app/schemas/user.py Reordered pydantic imports.
app/services/auth.py Revised import order, moving HTTP-related imports up.
app/models/base.py Reordered SQLAlchemy import statements.
app/models/stuff.py Reordered imports for clarity.
app/services/scheduler.py Added import of AsyncScheduler and IntervalTrigger, fixed duplicates.
app/models/user.py Reordered imports for consistency.
app/api/shakespeare.py Adjusted AsyncSession import order.
app/models/nonsense.py Reordered SQLAlchemy ORM import statements.
app/config.py Adjusted import order for pydantic elements.
app/api/stuff.py Reordered FastAPI imports.
app/api/health.py Reordered FastAPI imports for clarity.
app/database.py Consolidated SQLAlchemy async engine import formatting.
app/api/user.py Reordered API imports and adjusted User schema import order.
app/models/shakespeare.py Minor whitespace addition after imports.

Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

.github/workflows/build-and-test.yml:58

  • Ensure that the 'uv' command is available and correctly configured in your environment, or consider using an explicit Python invocation if 'uv' is not intended.
run: uv run --frozen ruff check .

app/schemas/nnonsense.py:1

  • The filename 'nnonsense.py' appears unusual; if this is a typographical error, consider renaming it to 'nonsense.py' for clarity and consistency.
from uuid import UUID

@grillazz grillazz merged commit 3f4f1ef into main Mar 8, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant