Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix for reading poscar reading #64

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Jul 28, 2024

Closes #60
Closes dftd4/dftd4#207

@awvwgk awvwgk added the bug Something isn't working label Jul 28, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 69.78%. Comparing base (77f65c6) to head (6ff2c52).
Report is 1 commits behind head on main.

Files Patch % Lines
test/test_read_vasp.f90 66.66% 0 Missing and 7 partials ⚠️
src/mctc/io/read/vasp.f90 0.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   69.79%   69.78%   -0.01%     
==========================================
  Files          64       64              
  Lines        8618     8639      +21     
  Branches     2579     2586       +7     
==========================================
+ Hits         6015     6029      +14     
- Misses        782      783       +1     
- Partials     1821     1827       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@awvwgk awvwgk merged commit 95d57e1 into grimme-lab:main Aug 1, 2024
9 of 11 checks passed
@awvwgk awvwgk deleted the poscar branch August 1, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant