feat: More readable Document settings #1376
Conversation
|
Take a look at this screenshot: The currency's description is slightly moved to the right. It happens when I'm making my screen narrower. It works ok on main branch. |
| @@ -106,7 +106,7 @@ const cssItem = styled('div', ` | |||
|
|
|||
| const cssItemShort = styled('div', ` | |||
| display: flex; | |||
| flex-wrap: wrap; | |||
| flex-wrap: nowrap; | |||
There was a problem hiding this comment.
Can you explain the reasoning behind this nowrap and the max width below?
There was a problem hiding this comment.
With french, (that takes more chars to express things that english) the last element of each row wraps, if flex-wrap: wrap; is set
But with flex-wrap:nowrap; its tays on the same line.
First implementation of gristlabs#1289
hexaltation
force-pushed
the
feat-ux-document-settings
branch
from
780b0cc to
e5cf459
Compare
Hello @berhalak After some jobs jobs, thing are aligned with smaller screen.
I've fixed DocumentId input width in my last commit, after screenshots. |
|
Deployed commit |
|
Deployed commit |
| @@ -162,7 +162,7 @@ export class DocSettingsPage extends Disposable { | |||
| }) : null, | |||
| ]), | |||
|
|
|||
| dom.create(AdminSection, t('API'), [ | |||
| dom.create(cssAdminSection, t('API'), [ | |||
There was a problem hiding this comment.
Can you take a look at AdminPanel.ts ? It also uses those styles, maybe we can just update the base component, without wrapping it into cssAdminSection. The goal was to have those two pages (DocumentSettings and AdminPanel) look very similar.
Partially fixes #1289
Context
#1015 mockup is completed with some Document settings page enhancement.
Proposed solution
The first proposal was in PR #1181.
As suggested by @berhalak It was removed from functional code to be done in this separate PR.
This PR only enroll Document setting page enhancements.
Two other PRs will propose:
Related issues
#1015
#1289
Has this been tested?