Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 719 header param table schema doc #287

Merged

Conversation

fflorent
Copy link
Collaborator

Document table-schema API.

Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for grist-help-preview ready!

Name Link
🔨 Latest commit 02c3174
🔍 Latest deploy log https://app.netlify.com/sites/grist-help-preview/deploys/6555e907d35acb0008c15939
😎 Deploy Preview https://deploy-preview-287--grist-help-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@paulfitz paulfitz self-requested a review November 15, 2023 15:58
Copy link
Member

@paulfitz paulfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fflorent.

api/grist.yml Outdated Show resolved Hide resolved
@fflorent fflorent requested a review from paulfitz November 16, 2023 08:55
type: string
enum: ["utf-8"]
dialect:
$ref: https://specs.frictionlessdata.io/schemas/csv-dialect.json
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you feel uncomfortable with referencing external references, I can download the JSON and either include the YAML in the document or index as is locally in the repository. (also same remark for schema).

@fflorent fflorent force-pushed the issue-719-header-param-table-schema-doc branch from 2124ff9 to 02c3174 Compare November 16, 2023 10:03
Copy link
Member

@paulfitz paulfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @fflorent !

@paulfitz paulfitz merged commit e2bd9a5 into gristlabs:master Nov 16, 2023
4 checks passed
fflorent added a commit to fflorent/grist-help that referenced this pull request Feb 13, 2024
Document table-schema and missing header parameter in download options

---------

Co-authored-by: Florent FAYOLLE <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants