-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
From weblate to gitlocalize #384
From weblate to gitlocalize #384
Conversation
✅ Deploy Preview for grist-help-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
5e09c09
to
e96c8f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Florent. This looks good, though I have a few questions.
The biggest one is: it doesn't seem to be possible to mark a translated article as good enough to not require warnings, i.e. it would always show either then "not yet translated" warning or "needs improvement" warning. Do you have a plan for that?
Also, I noticed that the French homepage shows both warnings. This doesn't seem right.
Also, could you please rebase your branch on the latest master
? There was a recent fix to an issue with the formatting of functions.md
(e.g. seen here), and it would be good to make sure it's not affected by your changes.
3bb5b17
to
6b537b8
Compare
I propose to declare a property to tell which documents have been reviewed by a human and can be considered of enough quality to remove the warning. I'll work on that next week if you agree on that proposal.
I removed the warning in dc98650, which is a commit of my other PR #388
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you! Leaving to you to merge in.
Thank you @dsagal! |
This PR:
docs.py
scriptFixes #370