Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From weblate to gitlocalize #384

Merged
merged 6 commits into from
Aug 27, 2024

Conversation

fflorent
Copy link
Collaborator

@fflorent fflorent commented Aug 14, 2024

This PR:

  • removes any mention of weblate in favor of gitlocalize
  • removes a function related to weblate in the docs.py script
  • warns about the translation being generated
  • allow people asking to help translating through github using the dedicated template. Regular issues can still be open. Preview available through my fork.

Fixes #370

Copy link

netlify bot commented Aug 14, 2024

Deploy Preview for grist-help-preview ready!

Name Link
🔨 Latest commit 6b537b8
🔍 Latest deploy log https://app.netlify.com/sites/grist-help-preview/deploys/66c88993943d8500082a20e2
😎 Deploy Preview https://deploy-preview-384--grist-help-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fflorent fflorent force-pushed the from-weblate-to-gitlocalize branch 2 times, most recently from 5e09c09 to e96c8f6 Compare August 21, 2024 08:22
@fflorent fflorent marked this pull request as ready for review August 21, 2024 08:58
Copy link
Member

@dsagal dsagal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Florent. This looks good, though I have a few questions.

The biggest one is: it doesn't seem to be possible to mark a translated article as good enough to not require warnings, i.e. it would always show either then "not yet translated" warning or "needs improvement" warning. Do you have a plan for that?

Also, I noticed that the French homepage shows both warnings. This doesn't seem right.

Also, could you please rebase your branch on the latest master? There was a recent fix to an issue with the formatting of functions.md (e.g. seen here), and it would be good to make sure it's not affected by your changes.

help/en/MISSING-TRANSLATION.md Outdated Show resolved Hide resolved
@fflorent fflorent force-pushed the from-weblate-to-gitlocalize branch from 3bb5b17 to 6b537b8 Compare August 23, 2024 13:07
@fflorent
Copy link
Collaborator Author

@dsagal

The biggest one is: it doesn't seem to be possible to mark a translated article as good enough to not require warnings, i.e. it would always show either then "not yet translated" warning or "needs improvement" warning. Do you have a plan for that?

I propose to declare a property to tell which documents have been reviewed by a human and can be considered of enough quality to remove the warning. I'll work on that next week if you agree on that proposal.

Also, I noticed that the French homepage shows both warnings. This doesn't seem right.

I removed the warning in dc98650, which is a commit of my other PR #388

Also, could you please rebase your branch on the latest master? There was a recent fix to an issue with the formatting of functions.md (e.g. seen here), and it would be good to make sure it's not affected by your changes.

Done!

Copy link
Member

@dsagal dsagal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! Leaving to you to merge in.

@fflorent
Copy link
Collaborator Author

Thank you @dsagal!

@fflorent fflorent merged commit ad12644 into gristlabs:master Aug 27, 2024
5 checks passed
@fflorent fflorent deleted the from-weblate-to-gitlocalize branch August 27, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Gitlocalize instead of Weblate
2 participants