Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes function searching and jumping #389

Merged
merged 7 commits into from
Aug 21, 2024
Merged

Fixes function searching and jumping #389

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cfb7159
Re-formats function header rendering
Spoffy Aug 20, 2024
182e0ed
Adds attr_list extension
Spoffy Aug 20, 2024
1c2363c
Fixes extra id being added
Spoffy Aug 20, 2024
3133634
Fixes TOC / search naming of functions
Spoffy Aug 21, 2024
62bccba
Updates and runs mkpydocs for functions
Spoffy Aug 21, 2024
7844f81
Fixes sections not expanding on jump
Spoffy Aug 21, 2024
61f04e2
Updates grist.css comments, changes loop to `.closest`
Spoffy Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions help/en/docs/css/grist.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,12 +319,12 @@ body {
* We want headers for the sake of searching, but don't want to see the huge padding and
* surrounding empty paragraphs.
*/
.wm-page-content summary h4,
.wm-page-content summary p {
.wm-page-content summary p:empty {
display: none;
}

/* The <code> block that serves as a function header annoyingly gets auto-wrapped in a <p> */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment out-of-date / no-longer-helpful now? The comment before the previous change also seems in need of an update.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated them to better reflect their uses!

.wm-page-content summary p:not(:first-child) {
.wm-page-content summary p:not(:first-child, :empty) {
display: inline-block;
margin: 0;
}
Expand Down
Loading
Loading