Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference Filtering Example Change #423

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Conversation

jr-grist
Copy link
Collaborator

Image updates; text updates to follow

Copy link

netlify bot commented Sep 18, 2024

Deploy Preview for grist-help-preview ready!

Name Link
🔨 Latest commit 141bd66
🔍 Latest deploy log https://app.netlify.com/sites/grist-help-preview/deploys/66f3e4f69b290500086af6fd
😎 Deploy Preview https://deploy-preview-423--grist-help-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@nataliemisasi nataliemisasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions. Will send you updated screenshots

help/en/docs/col-refs.md Outdated Show resolved Hide resolved
help/en/docs/col-refs.md Show resolved Hide resolved
help/en/docs/col-refs.md Outdated Show resolved Hide resolved
@nataliemisasi
Copy link
Collaborator

Also - a link to the example is not included.

https://public.getgrist.com/9XHx6mHSm7y4/Reference-Filtering/m/fork

This should be included somewhere towards the beginning of the section

@nataliemisasi nataliemisasi self-requested a review September 25, 2024 14:53
Copy link
Collaborator

@nataliemisasi nataliemisasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I tried to change some of the sizing on the images but nothing was an improvement. So we'll leave as is! Thanks for doing this 👍

@jr-grist jr-grist merged commit da43c4c into master Sep 25, 2024
5 checks passed
@jr-grist jr-grist deleted the references-filtering-updates branch September 25, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants