Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Invoice and Purchase Order widgets to make text visible in dark mode #110

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

dsagal
Copy link
Member

@dsagal dsagal commented Nov 14, 2023

CSS tweaks. Light mode looks the same as before the change.

Dark mode before:
Screenshot 2023-11-14 at 12 06 51 PM
Screenshot 2023-11-14 at 12 07 11 PM

Dark mode after:
Screenshot 2023-11-14 at 12 06 15 PM
Screenshot 2023-11-14 at 12 06 26 PM

Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for boisterous-sunburst-a5c941 ready!

Name Link
🔨 Latest commit eecba30
🔍 Latest deploy log https://app.netlify.com/sites/boisterous-sunburst-a5c941/deploys/6553abeb48902300086a1d4c
😎 Deploy Preview https://deploy-preview-110--boisterous-sunburst-a5c941.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@georgegevoian georgegevoian self-requested a review November 14, 2023 17:11
Copy link
Contributor

@georgegevoian georgegevoian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@georgegevoian georgegevoian self-requested a review November 14, 2023 17:13
@@ -54,7 +53,7 @@ body {

.client .details, .summary .details {
padding: 4px;
background: #fff;
background-color: var(--grist-theme-page-panels-main-panel-bg);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add fallbacks for these. (The variables don't always exist, like when custom CSS is enabled.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Done.

Copy link
Contributor

@georgegevoian georgegevoian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dsagal!

@dsagal dsagal merged commit 10c9026 into master Nov 14, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants