-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Invoice and Purchase Order widgets to make text visible in dark mode #110
Conversation
✅ Deploy Preview for boisterous-sunburst-a5c941 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
invoices/invoice.css
Outdated
@@ -54,7 +53,7 @@ body { | |||
|
|||
.client .details, .summary .details { | |||
padding: 4px; | |||
background: #fff; | |||
background-color: var(--grist-theme-page-panels-main-panel-bg); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to add fallbacks for these. (The variables don't always exist, like when custom CSS is enabled.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dsagal!
CSS tweaks. Light mode looks the same as before the change.
Dark mode before:
Dark mode after: