-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests broken due to widget gallery changes #144
Conversation
✅ Deploy Preview for boisterous-sunburst-a5c941 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Took a quick look at this PR. A few notes.
It looks pretty out of date with Copying a file across is of course lame. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! One note about a change which I suspect is not needed to get the fixes of this PR.
test/gristWebDriverUtils.ts
Outdated
@@ -210,8 +223,11 @@ export class GristWebDriverUtils { | |||
const max = 10; | |||
|
|||
// Keep dismissing prompts until there are no more, up to a maximum of 10 times. | |||
while (i < max && await this.driver.find('.test-behavioral-prompt').isPresent()) { | |||
await this.driver.find('.test-behavioral-prompt-dismiss').click(); | |||
const getButton = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My guess is that this change isn't of much benefit, and my preference would be to keep it unchanged, since it's a copy of code from grist-core (which is much more exercised and reliable). For the same reason, ignoreMissingElementErrors
doesn't seem needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rolled this back - totally agree it doesn't make sense making these changes, if we haven't updated gristWebDriverUtils.
No description provided.