forked from imotov/elasticsearch-zookeeper
-
Notifications
You must be signed in to change notification settings - Fork 18
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Release version 1.4.1 (compatibility with elasticsearch 1.4.1)
Thanks to Danny Wilson (github.com/vizanto)
- Loading branch information
Showing
1 changed file
with
3 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9620416
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it actually work in practice?
9620416
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In practice I can't upgrade (rolling or not) to this without #2. With those changes it seems to mostly work but in testing it I've run into a situation where all shards can go unassigned on stopping the current master. Difficult to reproduce but scary enough that don't want to upgrade till I can track down the cause.
9620416
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I have successfully upgraded my clusters (even without #2) and they are working without problems. YMMV.
9620416
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whether you can do (non-rolling) upgrade without #2 depends on what's in your cluster state (e.g. if you have snapshot repositories configured) - since there are only version checks reading the state in a couple places if you don't hit one you're fine. As for the unassigned shards on bouncing master, still hard to reproduce but I've hit it twice now, though don't know that it came in with 1.4.1 vs earlier (we've been running 1.1.0 & haven't seen it, but also don't restart nodes frequently.) On plus side recovery is kicked off if you subsequently stop another node, but...