-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch default debootstrap tool to mmdebstrap #291
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
shellcheck
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1887 in 59498c5
cp -a $VERBOSE "${_opt_chroot_scripts}"/* "${MNTPOINT}"/etc/debootstrap/chroot-scripts/ |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1891 in 59498c5
cp $VERBOSE "${CHROOT_VARIABLES}" "${MNTPOINT}"/etc/debootstrap/variables |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1893 in 59498c5
cp $VERBOSE -a -L "${CONFFILES}"/extrapackages/ "${MNTPOINT}"/etc/debootstrap/ |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1896 in 59498c5
[ -f "${MNTPOINT}"/etc/resolv.conf ] || cp $VERBOSE /etc/resolv.conf "${MNTPOINT}"/etc/resolv.conf |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1899 in 59498c5
[ -n "$LOCALES" ] && cp $VERBOSE "${CONFFILES}"/locale.gen "${MNTPOINT}"/etc/locale.gen |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1902 in 59498c5
[ -d "${CONFFILES}"/bin ] && cp $VERBOSE -a -L "${CONFFILES}"/bin/* "${MNTPOINT}"/bin/ |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1903 in 59498c5
[ -d "${CONFFILES}"/boot ] && cp $VERBOSE -a -L "${CONFFILES}"/boot/* "${MNTPOINT}"/boot/ |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1904 in 59498c5
[ -d "${CONFFILES}"/etc ] && cp $VERBOSE -a -L "${CONFFILES}"/etc/* "${MNTPOINT}"/etc/ |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1905 in 59498c5
[ -d "${CONFFILES}"/sbin ] && cp $VERBOSE -a -L "${CONFFILES}"/sbin/* "${MNTPOINT}"/sbin/ |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1906 in 59498c5
[ -d "${CONFFILES}"/share ] && cp $VERBOSE -a -L "${CONFFILES}"/share/* "${MNTPOINT}"/share/ |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1907 in 59498c5
[ -d "${CONFFILES}"/usr ] && cp $VERBOSE -a -L "${CONFFILES}"/usr/* "${MNTPOINT}"/usr/ |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1908 in 59498c5
[ -d "${CONFFILES}"/var ] && cp $VERBOSE -a -L "${CONFFILES}"/var/* "${MNTPOINT}"/var/ |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1963 in 59498c5
cp $VERBOSE /etc/network/interfaces "${MNTPOINT}/etc/network/interfaces" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
shellcheck (suggestion)
[shellcheck (suggestion)] reported by reviewdog 🐶
grml-debootstrap/grml-debootstrap
Line 1893 in 59498c5
cp $VERBOSE -a -L "${CONFFILES}"/extrapackages/ "${MNTPOINT}"/etc/debootstrap/ |
[shellcheck (suggestion)] reported by reviewdog 🐶
grml-debootstrap/grml-debootstrap
Line 1896 in 59498c5
[ -f "${MNTPOINT}"/etc/resolv.conf ] || cp $VERBOSE /etc/resolv.conf "${MNTPOINT}"/etc/resolv.conf |
[shellcheck (suggestion)] reported by reviewdog 🐶
grml-debootstrap/grml-debootstrap
Line 1899 in 59498c5
[ -n "$LOCALES" ] && cp $VERBOSE "${CONFFILES}"/locale.gen "${MNTPOINT}"/etc/locale.gen |
[shellcheck (suggestion)] reported by reviewdog 🐶
grml-debootstrap/grml-debootstrap
Lines 1902 to 1908 in 59498c5
[ -d "${CONFFILES}"/bin ] && cp $VERBOSE -a -L "${CONFFILES}"/bin/* "${MNTPOINT}"/bin/ | |
[ -d "${CONFFILES}"/boot ] && cp $VERBOSE -a -L "${CONFFILES}"/boot/* "${MNTPOINT}"/boot/ | |
[ -d "${CONFFILES}"/etc ] && cp $VERBOSE -a -L "${CONFFILES}"/etc/* "${MNTPOINT}"/etc/ | |
[ -d "${CONFFILES}"/sbin ] && cp $VERBOSE -a -L "${CONFFILES}"/sbin/* "${MNTPOINT}"/sbin/ | |
[ -d "${CONFFILES}"/share ] && cp $VERBOSE -a -L "${CONFFILES}"/share/* "${MNTPOINT}"/share/ | |
[ -d "${CONFFILES}"/usr ] && cp $VERBOSE -a -L "${CONFFILES}"/usr/* "${MNTPOINT}"/usr/ | |
[ -d "${CONFFILES}"/var ] && cp $VERBOSE -a -L "${CONFFILES}"/var/* "${MNTPOINT}"/var/ |
[shellcheck (suggestion)] reported by reviewdog 🐶
grml-debootstrap/grml-debootstrap
Line 1963 in 59498c5
cp $VERBOSE /etc/network/interfaces "${MNTPOINT}/etc/network/interfaces" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
shellcheck
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1899 in 6292d77
[ -n "$LOCALES" ] && cp $VERBOSE "${CONFFILES}"/locale.gen "${MNTPOINT}"/etc/locale.gen |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1902 in 6292d77
[ -d "${CONFFILES}"/bin ] && cp $VERBOSE -a -L "${CONFFILES}"/bin/* "${MNTPOINT}"/bin/ |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1903 in 6292d77
[ -d "${CONFFILES}"/boot ] && cp $VERBOSE -a -L "${CONFFILES}"/boot/* "${MNTPOINT}"/boot/ |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1904 in 6292d77
[ -d "${CONFFILES}"/etc ] && cp $VERBOSE -a -L "${CONFFILES}"/etc/* "${MNTPOINT}"/etc/ |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1905 in 6292d77
[ -d "${CONFFILES}"/sbin ] && cp $VERBOSE -a -L "${CONFFILES}"/sbin/* "${MNTPOINT}"/sbin/ |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1906 in 6292d77
[ -d "${CONFFILES}"/share ] && cp $VERBOSE -a -L "${CONFFILES}"/share/* "${MNTPOINT}"/share/ |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1907 in 6292d77
[ -d "${CONFFILES}"/usr ] && cp $VERBOSE -a -L "${CONFFILES}"/usr/* "${MNTPOINT}"/usr/ |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1908 in 6292d77
[ -d "${CONFFILES}"/var ] && cp $VERBOSE -a -L "${CONFFILES}"/var/* "${MNTPOINT}"/var/ |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1963 in 6292d77
cp $VERBOSE /etc/network/interfaces "${MNTPOINT}/etc/network/interfaces" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
shellcheck (suggestion)
[shellcheck (suggestion)] reported by reviewdog 🐶
grml-debootstrap/grml-debootstrap
Line 1893 in 6292d77
cp $VERBOSE -a -L "${CONFFILES}"/extrapackages/ "${MNTPOINT}"/etc/debootstrap/ |
[shellcheck (suggestion)] reported by reviewdog 🐶
grml-debootstrap/grml-debootstrap
Line 1896 in 6292d77
[ -f "${MNTPOINT}"/etc/resolv.conf ] || cp $VERBOSE /etc/resolv.conf "${MNTPOINT}"/etc/resolv.conf |
[shellcheck (suggestion)] reported by reviewdog 🐶
grml-debootstrap/grml-debootstrap
Line 1899 in 6292d77
[ -n "$LOCALES" ] && cp $VERBOSE "${CONFFILES}"/locale.gen "${MNTPOINT}"/etc/locale.gen |
[shellcheck (suggestion)] reported by reviewdog 🐶
grml-debootstrap/grml-debootstrap
Lines 1902 to 1908 in 6292d77
[ -d "${CONFFILES}"/bin ] && cp $VERBOSE -a -L "${CONFFILES}"/bin/* "${MNTPOINT}"/bin/ | |
[ -d "${CONFFILES}"/boot ] && cp $VERBOSE -a -L "${CONFFILES}"/boot/* "${MNTPOINT}"/boot/ | |
[ -d "${CONFFILES}"/etc ] && cp $VERBOSE -a -L "${CONFFILES}"/etc/* "${MNTPOINT}"/etc/ | |
[ -d "${CONFFILES}"/sbin ] && cp $VERBOSE -a -L "${CONFFILES}"/sbin/* "${MNTPOINT}"/sbin/ | |
[ -d "${CONFFILES}"/share ] && cp $VERBOSE -a -L "${CONFFILES}"/share/* "${MNTPOINT}"/share/ | |
[ -d "${CONFFILES}"/usr ] && cp $VERBOSE -a -L "${CONFFILES}"/usr/* "${MNTPOINT}"/usr/ | |
[ -d "${CONFFILES}"/var ] && cp $VERBOSE -a -L "${CONFFILES}"/var/* "${MNTPOINT}"/var/ |
[shellcheck (suggestion)] reported by reviewdog 🐶
grml-debootstrap/grml-debootstrap
Line 1963 in 6292d77
cp $VERBOSE /etc/network/interfaces "${MNTPOINT}/etc/network/interfaces" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should also adjust README.md
:
-This tool is a wrapper suite around debootstrap and cdebootstrap
+This tool is a wrapper suite around debootstrap and mmdebstrap
and also adapt grml-debootstrap.8.txt
accordingly?
1756ef3
to
bab6ccc
Compare
Indeed, done. I have left the parts mentioning just debootstrap alone for now, we can continue the discussion in #209. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
shellcheck
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1880 in 1756ef3
[ -f "${_opt_debconf}" ] && [ "$DEBCONF" = 'yes' ] && \ |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1883 in 1756ef3
# copy scripts that should be executed inside the chroot: |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1884 in 1756ef3
_opt_chroot_scripts=${_opt_chroot_scripts:-$CONFFILES/chroot-scripts/} |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1885 in 1756ef3
[ -d "$_opt_chroot_scripts" ] && [ "$CHROOT_SCRIPTS" = 'yes' ] && { |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1886 in 1756ef3
mkdir -p "${MNTPOINT}"/etc/debootstrap/chroot-scripts |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1887 in 1756ef3
cp -a $VERBOSE "${_opt_chroot_scripts}"/* "${MNTPOINT}"/etc/debootstrap/chroot-scripts/ |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1888 in 1756ef3
} |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1889 in 1756ef3
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1944 in 1756ef3
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
shellcheck (suggestion)
[shellcheck (suggestion)] reported by reviewdog 🐶
grml-debootstrap/grml-debootstrap
Line 1944 in 1756ef3
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
shellcheck
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1868 in bab6ccc
PACKAGES_FILE="packages" |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1872 in bab6ccc
fi |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1874 in bab6ccc
cp $VERBOSE "${_opt_packages:-$CONFFILES/$PACKAGES_FILE}" \ |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1877 in bab6ccc
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1880 in bab6ccc
[ -f "${_opt_debconf}" ] && [ "$DEBCONF" = 'yes' ] && \ |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1883 in bab6ccc
# copy scripts that should be executed inside the chroot: |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1884 in bab6ccc
_opt_chroot_scripts=${_opt_chroot_scripts:-$CONFFILES/chroot-scripts/} |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1885 in bab6ccc
[ -d "$_opt_chroot_scripts" ] && [ "$CHROOT_SCRIPTS" = 'yes' ] && { |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1886 in bab6ccc
mkdir -p "${MNTPOINT}"/etc/debootstrap/chroot-scripts |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1887 in bab6ccc
cp -a $VERBOSE "${_opt_chroot_scripts}"/* "${MNTPOINT}"/etc/debootstrap/chroot-scripts/ |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1888 in bab6ccc
} |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1889 in bab6ccc
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
grml-debootstrap/grml-debootstrap
Line 1944 in bab6ccc
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
shellcheck (suggestion)
[shellcheck (suggestion)] reported by reviewdog 🐶
grml-debootstrap/grml-debootstrap
Line 1874 in bab6ccc
cp $VERBOSE "${_opt_packages:-$CONFFILES/$PACKAGES_FILE}" \ |
[shellcheck (suggestion)] reported by reviewdog 🐶
grml-debootstrap/grml-debootstrap
Line 1877 in bab6ccc
[shellcheck (suggestion)] reported by reviewdog 🐶
grml-debootstrap/grml-debootstrap
Line 1880 in bab6ccc
[ -f "${_opt_debconf}" ] && [ "$DEBCONF" = 'yes' ] && \ |
[shellcheck (suggestion)] reported by reviewdog 🐶
grml-debootstrap/grml-debootstrap
Lines 1883 to 1889 in bab6ccc
# copy scripts that should be executed inside the chroot: | |
_opt_chroot_scripts=${_opt_chroot_scripts:-$CONFFILES/chroot-scripts/} | |
[ -d "$_opt_chroot_scripts" ] && [ "$CHROOT_SCRIPTS" = 'yes' ] && { | |
mkdir -p "${MNTPOINT}"/etc/debootstrap/chroot-scripts | |
cp -a $VERBOSE "${_opt_chroot_scripts}"/* "${MNTPOINT}"/etc/debootstrap/chroot-scripts/ | |
} | |
[shellcheck (suggestion)] reported by reviewdog 🐶
grml-debootstrap/grml-debootstrap
Line 1944 in bab6ccc
fi |
mmdebstrap is the modern, fast tool. grml-small comes with mmdebstrap but not debootstrap, so it's really necessary there. Closes: #290
mmdebstrap is the modern, fast tool. grml-small comes with mmdebstrap but not debootstrap, so it's really necessary there.
Closes: #290