Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interactive mode: ignore failures when identifying file system fails #296

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

mika
Copy link
Member

@mika mika commented Nov 29, 2024

When booting Grml from a YUMI device (see https://yumiusb.com/) which was built with Ventoy, then executing blkid -s TYPE -o value /dev/dm-0p1 might fail, if ventoy is behind the /dev/dm-0p1 device:

root@grml:~# dmsetup ls
ventoy  (253:0)

Fixes:

++ for i in $AVAILABLE_PARTITIONS
+++ blkid -s TYPE -o value /dev/dm-0p1
++++ error_handler
++++ last_exit_code=2
++++ last_bash_command='blkid -s TYPE -o value "$i" 2> /dev/null' ++++ echo 'Unexpected non-zero exit code 2 in /usr/sbin/grml-debootstrap /usr/sbin/grml-debootstrap /usr/sbin/grml-debootstrap /usr/sbin/grml-debootstrap at line 744 1151 1166 0 detected! last bash command: blkid -s TYPE -o value "$i" 2> /dev/null' ++++ '[' -r /mnt/debootstrap.5465/debootstrap/debootstrap.log ']'

Thanks to klatls for the bug report

When booting Grml from a YUMI device (see https://yumiusb.com/) which
was built with Ventoy, then executing `blkid -s TYPE -o value /dev/dm-0p1` might fail, if ventoy is behind the /dev/dm-0p1:

| root@grml:~# dmsetup ls
| ventoy  (253:0)

Fixes:

++ for i in $AVAILABLE_PARTITIONS
+++ blkid -s TYPE -o value /dev/dm-0p1
++++ error_handler
++++ last_exit_code=2
++++ last_bash_command='blkid -s TYPE -o value "$i" 2> /dev/null'
++++ echo 'Unexpected non-zero exit code 2 in /usr/sbin/grml-debootstrap /usr/sbin/grml-debootstrap /usr/sbin/grml-debootstrap /usr/sbin/grml-debootstrap at line 744 1151 1166 0 detected!
last bash command: blkid -s TYPE -o value "$i" 2> /dev/null'
++++ '[' -r /mnt/debootstrap.5465/debootstrap/debootstrap.log ']'

Thanks to klatls for the bug report
@mika mika merged commit 770eaa3 into master Dec 3, 2024
78 checks passed
@mika mika deleted the mika/ventoy branch December 3, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants