Ensure files are copied with fcopy into chroot with expected permissions #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeha
approved these changes
Dec 18, 2024
When running grml-live from within the git repository that was cloned by a user other than root, the files installed by FAI's fcopy have wrong/unexpected permissions. For example: | # stat /home/mika/build/grml-live-2024-12/grml_chroot/etc/rsyslog.conf | File: /home/mika/build/grml-live-2024-12/grml_chroot/etc/rsyslog.conf | Size: 1106 Blocks: 8 IO Block: 4096 regular file | Device: 253,2 Inode: 4472261 Links: 1 | Access: (0644/-rw-r--r--) Uid: ( 1000/ mika) Gid: ( 1000/ mika) | Access: 2024-12-18 15:39:59.477471695 +0100 | Modify: 2023-08-07 13:32:24.000000000 +0200 | Change: 2024-12-10 17:02:16.177262515 +0100 | Birth: 2024-12-10 17:02:16.177262515 +0100 fcopy provides the following options: | % fcopy -h | fcopy, copy files using classes. | [...] | -m user,group,mode Set user, group and mode for copied files. | -M Same as -m root,root,0644 | [...] Execute all fcopy command lines with `-M`, except for the ones that need execute permission (being /usr/share/initramfs-tools/scripts/init-top/grml and /etc/initramfs-tools/hooks/000-udev-shutup) or 0440 (/etc/sudoers), for which we use the `-m` option accordingly then. Thanks to Chris for spotting and feedback.
zeha
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running grml-live from within the git repository that was cloned by a user other than root, the files installed by FAI's fcopy have wrong/unexpected permissions.
For example:
fcopy provides the following options:
Execute all fcopy command lines with
-M, except for the ones that need execute permission (being /usr/share/initramfs-tools/scripts/init-top/grml and /etc/initramfs-tools/hooks/000-udev-shutup) for which we use the-moption accordingly then.