build-driver: ship ipxe + memtest86+; grml-live: fix NO_ADDONS autodetection #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tection On arm64 we ended up with the following addon behavior: [*] Installing boot addons. [x] Missing addon file: "ipxe.lkrn" [x] Missing addon file: "ipxe.efi" [x] Missing addon file: "memtest86+.bin" [x] Missing addon file: bsd4grml And on amd64 we ended up with the following addon behavior: [*] Installing boot addons. [x] Missing addon file: "ipxe.lkrn" [x] Missing addon file: "ipxe.efi" [x] Missing addon file: "memtest86+x64.efi" [x] Missing addon file: "memtest86+x64.bin" [x] Missing addon file: "memtest86+.bin" [x] Missing addon file: bsd4grml Now by not using the NO_ADDONS autodetection and shipping ipxe on amd64 + arm64 and memtest86+ on amd64 only (it's not available for arm64), we get the expected behavior, as in: On arm64: [*] Installing boot addons. [x] Missing addon file: "memtest86+.bin" [x] Missing addon file: bsd4grml On amd64: [*] Installing boot addons. [x] Missing addon file: bsd4grml Fixes commit a2a16ec Related to #161 and #128
zeha
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On arm64 we ended up with the following addon behavior:
And on amd64 we ended up with the following addon behavior:
Now by not using the NO_ADDONS autodetection and shipping ipxe on amd64 + arm64 and memtest86+ on amd64 only (it's not available for arm64), we get the expected behavior, as in:
On arm64:
On amd64:
Fixes commit a2a16ec Related to #161 and #128