FIXMEs need to be bugs

groton-school · Aug 1, 2024 · 8f2f2cf · 8f2f2cf
1 parent 341818e
commit 8f2f2cf
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/.nova/Configuration.json b/.nova/Configuration.json
@@ -1,4 +1,6 @@
 {
-  "workspace.art_style" : 1,
-  "workspace.color" : 8
+  "todo.workspace-ignore-names": [""],
+  "todo.workspace-ignore-paths": ["./.grpcio"],
+  "workspace.art_style": 1,
+  "workspace.color": 8
 }
diff --git a/apps/router/src/Handlers/Factories/CloudStorageRouter.ts b/apps/router/src/Handlers/Factories/CloudStorageRouter.ts
@@ -102,7 +102,7 @@ const CloudStorageRouter: HandlerFactory = ({ config, index, groups } = {}) => {
         } catch (error) {
           if (error == 'Error: No refresh token is set.') {
             // silent login if refresh token not present
-            // FIXME this should be caught in Auth.authorize
+            // TODO this should be caught/handled in Auth.authorize, not here
             req.session.redirect = req.url.replace(`https://${req.host}`, '');
             res.redirect(Auth.authUrl);
           } else {

diff --git a/packages/index/src/Actions/pipelineHTML.ts b/packages/index/src/Actions/pipelineHTML.ts
@@ -1,6 +1,8 @@
 import File from '../File';
 import { JSDOM } from 'jsdom';
 
+// TODO pipelineHTML needs a re-think
+
 type PipelineFunction = (params: { file: File; html: string }) => string;
 
 const injectGoogleDocId: PipelineFunction = ({ file, html }) => {

diff --git a/packages/index/src/File.ts b/packages/index/src/File.ts
@@ -1,4 +1,3 @@
-// FIXME this is so bad!
 import pipelineHTML from './Actions/pipelineHTML';
 import IndexEntry from './IndexEntry';
 import { JSONObject } from '@battis/typescript-tricks';