Add support for overriding HLSL register/spaces #180
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting from GLSL to HLSL, automatic register assignment causes bindings that use multiple registers to overlap. This adds support for overriding the assignment by exposing
CompilerHLSL::add_hlsl_resource_binding
in spirv-cross.Before (automatic behavior):
This fails to compile because
shadow_map_images
overlapsshadow_map_images_cube
in this example.After (behavior provided by calling the added
add_resource_binding
which callsCompilerHLSL::add_hlsl_resource_binding
: