Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgraded golang.org/x/oauth2 #8174

Closed
wants to merge 4 commits into from
Closed

Conversation

kaanyalti
Copy link

@kaanyalti kaanyalti commented Mar 14, 2025

Upgrades oauth2 package to latest

Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.06%. Comparing base (b0d1203) to head (0e65e4a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8174      +/-   ##
==========================================
- Coverage   82.06%   82.06%   -0.01%     
==========================================
  Files         410      410              
  Lines       40233    40233              
==========================================
- Hits        33018    33016       -2     
  Misses       5854     5854              
- Partials     1361     1363       +2     

see 18 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kaanyalti
Copy link
Author

running go mod tidy does not change anything, can anyone help resolve the ci failures?

@kaanyalti kaanyalti closed this Mar 14, 2025
@kaanyalti kaanyalti reopened this Mar 14, 2025
@eshitachandwani
Copy link
Member

Hi @kaanyalti , you will need to update the dependencies in other files using oauth2 as well. This line means that you need to run go mod tidy inside the security/advancedtls . Similarly , you can use grep to find all files that have oauth2 dependency like grep -r --include="go.mod" "oauth2"

@eshitachandwani eshitachandwani added Area: Tooling Includes anything related to Go builds, modules etc and includes Releases & Github Workflows. Status: Requires Reporter Clarification labels Mar 23, 2025
@eshitachandwani
Copy link
Member

Hey @kaanyalti , we already bump the dependencies when we do a new release , is there a specific reason that you are trying to bump the dependency for ? Is it blocking you ? Closing the PR , we will do a bump when doing a new release. Feel free to reopen it if you need it urgently or if it is blocking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Tooling Includes anything related to Go builds, modules etc and includes Releases & Github Workflows. Status: Requires Reporter Clarification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants