grpclb: fix a bug in handling server address updates. #2754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It didn't check if the address was already there in the current subchannel set before creating a new subchannel for it, causing a leak of subchannels.
|
I remember I had a comment on this before in #2557 and you replied
Was that the same concern as this PR? |
|
never mind, I understood that. |
| @@ -601,15 +601,20 @@ public void grpclbWorking() { | |||
| assertSame(error1, picker6.result.getStatus()); | |||
|
|
|||
| // Update backends, with a drop entry | |||
| List<InetSocketAddress> backends2 = Arrays.asList( | |||
| new InetSocketAddress("127.0.0.1", 2030), null); | |||
| List<InetSocketAddress> backends2 = | |||
There was a problem hiding this comment.
This test code may be too long. Maybe it's testing multiple things that could be separated?
There was a problem hiding this comment.
I agree the state of this test method is not ideal. Although it's testing multiple behaviors, every test depends the state left by the the previous tests as prerequisites, therefore it's non-trivial to split them apart, and I don't have the time to do it.
dapengzhang0
approved these changes
Mar 1, 2017
|
ref #2772 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It didn't check if the address was already there in the current
subchannel set before creating a new subchannel for it, causing a leak
of subchannels.