feat(grpc-js): allow configurable http2 initial window size #2864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
murgatroid99
reviewed
Dec 6, 2024
There was a problem hiding this comment.
I think grpc-node.flow_control_window would be a better option name, to match the Java implementation. If we implement dynamic window sizes in the future, "initial window size" would be a better name for that option, again keeping with the Java implementation.
| }, | ||
| settings: { | ||
| initialWindowSize: | ||
| options['grpc-node.http2_initial_window_size'] || |
There was a problem hiding this comment.
Please use ?? instead of || for consistency with the rest of the codebase.
|
Thanks for the comments, I'll fix these as soon as I can, I'm just waiting for approval from the open source committee in my company. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for setting an
initialWindowSizein the http2 session. This fixes #2429, as described in the issue the default window size is 64Kb which is OK for typical http2 use cases but isn't so good for usage inside internal networks with larger response sizes.I have chosen to add a channel option to implement this as it seemed the most sensible way to make this change. Please advise if there is a better way to achieve this.