Types can be resolved where the constructor has a default parameter, … #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as long as the compiler emitting the type supports default parameters (i.e [Optional]/ System.Reflection.ParameterInfo.IsOptional). The resolution code checks whether the parameter IsOptional is true and then uses that default, if no parameter value is supplied.
|
This commit resolves #50 . |
|
Hello, Could you please fix the unit test conflicts and we'll get this merged in |
|
Ok, thanks, I'll try to sort this soon, but haven't looked at it in ages. |
|
Just checking back to see if you had any time to resolve the conflicts :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…as long as the compiler emitting the type supports default parameters (i.e [Optional]/ System.Reflection.ParameterInfo.IsOptional).
The resolution code checks whether the parameter IsOptional is true and then uses that default, if no parameter value is supplied.