implement UnregisterMultiple #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // if (!registrationType.GetTypeInfo().IsAssignableFrom(type.GetTypeInfo())) | ||
| //#else | ||
| if (!registrationType.IsAssignableFrom(type)) | ||
| //#endif |
There was a problem hiding this comment.
I was unsure about including the commented out #if NETFX_CORE. This code was copied from the implementation of public MultiRegisterOptions RegisterMultiple(Type registrationType, IEnumerable<Type> implementationTypes) so I left it in for consistency.
|
Could you please resolve the merge conflicts and well get this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of
UnregisterMultiple. The main reason this is needed is thatRegisterMultipleuses a convention to register each type as a named type with the full name of the type. Therefore if you had previous registered a type using......you would then have to unregister the type using...
This is a little unintuitive. This PR allows you to unregister the type using...
...which is the same syntax that the type was originally registered.