Moved the metadata into setup.cfg
#116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KOLANICH
force-pushed
the
setup.cfg
branch
2 times, most recently
from
4094e05
to
ab76eb2
Compare
alexmojaki
reviewed
Feb 23, 2022
|
+1 for removing exec, see #87 I quite like the setup in my own packages like https://github.com/alexmojaki/executing which was also initially introduced by @KOLANICH. It's minimal and very standard, see e.g. setup.py. @gruns are you attached to the commands in your setup.py? For publishing I use https://github.com/alexmojaki/executing/blob/master/make_release.sh. Is being able to run |
|
@alexmojaki, BTW you should be able to remove |
Version is now populated automatically from git using `setuptools_scm`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
pyproject.tomlVersion is now populated automatically from git using
setuptools_scm.I had to remove everything from
metaexcept the version (it can be fetched and populated, but it will slow down loading the module and I really doubt anyone ever relied on this API) and also removed the very suspiciousexeccall that has no legit reason to be present in this lib.