Mypy type checking #167
Open
Mypy type checking #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palfrey
commented
Nov 25, 2023
| - python-version: 2.7 | ||
| toxenv: py27 | ||
| # - python-version: 2.7 | ||
| # toxenv: py27 |
There was a problem hiding this comment.
The 2.7 bits either need fixing or removing elsewhere before this gets merged
|
@palfrey this is AWESOME. HUGE thank you for this PR 🙌 ill review this soon and provide any feedback necessary before merging. ship ship ship |
Hey. How's it going on this? |
|
@gruns Given I'm seeing recent changes to this repo, if I resolved the conflicts here, is it likely to get reviewed/merged soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds type checking. I think I've setup tox correctly, but not entirely sure.