Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New workflow for testing creating baseline PRs #49

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ZachGoldberg
Copy link
Contributor

@ZachGoldberg ZachGoldberg commented Jul 9, 2024

TODO: Document how to use this to test making custom account baselines
TODO: Figure out if there's a way to get account IDs to work without the provision step for accounts that have infact already been provisioned

Related to https://github.com/gruntwork-io/pipelines-actions/pull/40

@ZachGoldberg ZachGoldberg requested a review from yhakbar July 9, 2024 15:48
GRUNTWORK_INSTALLER_VERSION: v0.0.40

jobs:
pipelines_determine:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pipelines_determine:
pipelines_execute:

required: true
INFRA_ROOT_WRITE_TOKEN:
required: true
OPSGENIE_API_KEY:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
OPSGENIE_API_KEY:

INFRA_ROOT_WRITE_TOKEN:
required: true
OPSGENIE_API_KEY:
required: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
required: true

uses: actions/checkout@v4
with:
path: pipelines-actions
repository: Informa-Unity/pipelines-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
repository: Informa-Unity/pipelines-actions
repository: gruntwork-io/pipelines-actions

uses: actions/checkout@v4
with:
path: pipelines-actions-customizations
repository: Informa-Unity/pipelines-actions-customizations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
repository: Informa-Unity/pipelines-actions-customizations
repository: gruntwork-io/pipelines-actions-customizations

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this doesn't exist.

branch: "main"
working_directory: "."
account_id: "123456"
terragrunt_command: apply
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend parameterizing this.

change_type: AccountsRequested
branch: "main"
working_directory: "."
account_id: "123456"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend parameterizing this

token: ${{ secrets.PIPELINES_READ_TOKEN }}
change_type: AccountsRequested
branch: "main"
working_directory: "."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend parameterizing this.

uses: ./pipelines-actions/.github/actions/pipelines-bootstrap
with:
token: ${{ secrets.PIPELINES_READ_TOKEN }}
change_type: AccountsRequested
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend parameterizing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants