Improved errors handling for HCL functions (#3544)

* Improved multi error handling * multi error handling * Lint error fixes
gruntwork-io · Nov 11, 2024 · a4e26e2 · a4e26e2
1 parent 8f096d3
commit a4e26e2
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/config/config_helpers.go b/config/config_helpers.go
@@ -1114,7 +1114,7 @@ func extractSopsErrors(err error) *errors.MultiError {
 	}
 
 	// append the original error if no group results were found
-	if errs == nil {
+	if errs.Len() == 0 {
 		errs = errs.Append(err)
 	}
 

diff --git a/internal/errors/multierror.go b/internal/errors/multierror.go
@@ -46,11 +46,23 @@ func (errs *MultiError) Append(appendErrs ...error) *MultiError {
 		errs = &MultiError{inner: new(multierror.Error)}
 	}
 
+	if errs.inner == nil {
+		errs.inner = new(multierror.Error)
+	}
+
 	return &MultiError{inner: multierror.Append(errs.inner, appendErrs...)}
 }
 
 // Len implements sort.Interface function for length.
 func (errs *MultiError) Len() int {
+	if errs == nil {
+		errs = &MultiError{inner: new(multierror.Error)}
+	}
+
+	if errs.inner == nil {
+		errs.inner = new(multierror.Error)
+	}
+
 	return len(errs.inner.Errors)
 }
 

diff --git a/test/integration_sops_test.go b/test/integration_sops_test.go
@@ -111,4 +111,6 @@ func TestSopsDecryptOnMissing(t *testing.T) {
 	require.Error(t, err)
 
 	assert.Contains(t, errorOut, "Encountered error while evaluating locals in file ./terragrunt.hcl")
+	assert.Contains(t, errorOut, "./missing.yaml: no such file")
+
 }