fix: golint

cli/app.go

@@ -134,7 +134,7 @@ func (app *App) RunContext(ctx context.Context, args []string) error {
 		}
 	}(ctx)
 
-	args = RemoveNoColorDuplicates(args)
+	args = removeNoColorFlagDuplicates(args)
 
 	if err := app.App.RunContext(ctx, args); err != nil && !errors.IsContextCanceled(err) {
 		return err
@@ -143,8 +143,8 @@ func (app *App) RunContext(ctx context.Context, args []string) error {
 	return nil
 }
 
-func RemoveNoColorDuplicates(args []string) []string {
-	var (
+func removeNoColorFlagDuplicates(args []string) []string {
+	var ( //nolint:prealloc
 		foundNoColor bool
 		filteredArgs []string
 	)
@@ -154,6 +154,7 @@ func RemoveNoColorDuplicates(args []string) []string {
 			if foundNoColor {
 				continue
 			}
+
 			foundNoColor = true
 		}
 

cli/flags/flag.go

@@ -197,13 +197,14 @@ func autoEnvVar(name string) string {
 }
 
 func deprecatedNames(names []string) ([]string, []string) {
-	var deprecatedNames, deprecatedEnvVars []string
-
-	for _, name := range names {
-		envVarSuffix := strings.ToUpper(strings.ReplaceAll(name, "-", "_"))
-
-		deprecatedEnvVars = append(deprecatedEnvVars, DeprecatedEnvVarPrefix+envVarSuffix)
-		deprecatedNames = append(deprecatedNames, DeprecatedFlagNamePrefix+name)
+	var (
+		deprecatedNames   = make([]string, len(names))
+		deprecatedEnvVars = make([]string, len(names))
+	)
+
+	for i := range names {
+		deprecatedEnvVars[i] = DeprecatedEnvVarPrefix + strings.ToUpper(strings.ReplaceAll(names[i], "-", "_"))
+		deprecatedNames[i] = DeprecatedFlagNamePrefix + names[i]
 	}
 
 	return deprecatedNames, deprecatedEnvVars

test/integration_scaffold_test.go

@@ -134,7 +134,7 @@ func TestScaffoldErrorNoModuleUrl(t *testing.T) {
 	tmpEnvPath, err := os.MkdirTemp("", "terragrunt-scaffold-test")
 	require.NoError(t, err)
 
-	_, _, err = helpers.RunTerragruntCommandWithOutput(t, fmt.Sprintf("terragrunt scaffold --terragrunt-non-interactive --terragrunt-working-dir %s", tmpEnvPath))
+	_, _, err = helpers.RunTerragruntCommandWithOutput(t, "terragrunt scaffold --terragrunt-non-interactive --terragrunt-working-dir "+tmpEnvPath)
 	require.Error(t, err)
 	assert.Contains(t, err.Error(), "No module URL passed")
 }
@@ -197,6 +197,6 @@ func TestScaffold3rdPartyModule(t *testing.T) {
 	assert.FileExists(t, tmpEnvPath+"/terragrunt.hcl")
 
 	// validate the generated files
-	_, _, err = helpers.RunTerragruntCommandWithOutput(t, fmt.Sprintf("terragrunt hclvalidate --terragrunt-non-interactive --terragrunt-working-dir %s", tmpEnvPath))
+	_, _, err = helpers.RunTerragruntCommandWithOutput(t, "terragrunt hclvalidate --terragrunt-non-interactive --terragrunt-working-dir "+tmpEnvPath)
 	require.NoError(t, err)
 }