Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add aws/ecrpublic module #1293

Closed
wants to merge 1 commit into from
Closed

Feat: add aws/ecrpublic module #1293

wants to merge 1 commit into from

Conversation

matiri132
Copy link

@matiri132 matiri132 commented May 22, 2023

Description

This is the code for the issue: #1288
It creates the AWS ECR-Public module to interact with ECR public repositories.
Backward compatibility is maintained. The test temporarily creates a ECR public repository

Test outputs: https://gist.github.com/matiri132/e079eb89a61028ee89d244b991bc19bd

TODOs

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added ecrpublc module to support interaction with ECR public repositories.

@ellisonc
Copy link

@matiri132 Thanks for the contribution, this is looking great so far. Tests are currently failing because we recently refactored our circleci contexts. can you rebase on master? that should fix the tests.

@matiri132 matiri132 closed this by deleting the head repository May 23, 2023
@matiri132 matiri132 mentioned this pull request May 23, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants