-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wrong timezone in notice detail #554
base: development
Are you sure you want to change the base?
Conversation
📝 Walkthrough워크스루이 풀 리퀘스트는 변경 사항
가능한 관련 PR
제안된 리뷰어
시
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
lib/app/modules/notices/presentation/widgets/notice_renderer.dart (1)
175-175
: 날짜 포맷팅 로직 리팩토링 제안현재 파일 내에서 여러 곳에서 동일한 날짜 포맷팅 패턴이 반복되고 있습니다. 재사용 가능한 유틸리티 함수로 분리하는 것을 고려해보세요.
// utils/date_formatter.dart String formatDateTime(DateTime dateTime) { return DateFormat.yMd().add_Hm().format(dateTime.toLocal()); }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
lib/app/modules/notices/presentation/widgets/notice_renderer.dart
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Build Android App and Test
- GitHub Check: Build iOS App and Test
🔇 Additional comments (1)
lib/app/modules/notices/presentation/widgets/notice_renderer.dart (1)
175-175
: 날짜가 올바른 시간대로 표시되도록 수정되었습니다.
toLocal()
을 추가하여 공지사항 작성일이 사용자의 로컬 시간대로 올바르게 표시되도록 수정되었습니다.
Summary by CodeRabbit