Remove commented-out code.

gsketefian · Nov 25, 2024 · fedb5d7 · fedb5d7
1 parent 5b78792
commit fedb5d7
Show file tree

Hide file tree

Showing 7 changed files with 0 additions and 129 deletions.
diff --git a/scripts/exregional_run_met_genensprod_or_ensemblestat.sh b/scripts/exregional_run_met_genensprod_or_ensemblestat.sh
@@ -100,9 +100,6 @@ CDATE="${PDY}${cyc}"
 #
 #-----------------------------------------------------------------------
 #
-#FIELDNAME_IN_OBS_INPUT=""
-#FIELDNAME_IN_FCST_INPUT=""
-#FIELDNAME_IN_MET_OUTPUT=""
 FIELDNAME_IN_MET_FILEDIR_NAMES=""
 
 set_vx_params \
@@ -111,10 +108,6 @@ set_vx_params \
   accum_hh="${ACCUM_HH}" \
   outvarname_grid_or_point="grid_or_point" \
   outvarname_fieldname_in_MET_filedir_names="FIELDNAME_IN_MET_FILEDIR_NAMES"
-
-#  outvarname_fieldname_in_obs_input="FIELDNAME_IN_OBS_INPUT" \
-#  outvarname_fieldname_in_fcst_input="FIELDNAME_IN_FCST_INPUT" \
-#  outvarname_fieldname_in_MET_output="FIELDNAME_IN_MET_OUTPUT" \
 #
 #-----------------------------------------------------------------------
 #
@@ -395,10 +388,6 @@ settings="\
 ${vx_config_dict:-}
 "
 
-#'fieldname_in_obs_input': '${FIELDNAME_IN_OBS_INPUT}'
-#'fieldname_in_fcst_input': '${FIELDNAME_IN_FCST_INPUT}'
-#'fieldname_in_met_output': '${FIELDNAME_IN_MET_OUTPUT}'
-
 # Render the template to create a METplus configuration file
 tmpfile=$( $READLINK -f "$(mktemp ./met_plus_settings.XXXXXX.yaml)")
 printf "%s" "$settings" > "$tmpfile"

diff --git a/scripts/exregional_run_met_gridstat_or_pointstat_vx.sh b/scripts/exregional_run_met_gridstat_or_pointstat_vx.sh
@@ -95,9 +95,6 @@ echo "OBS_DIR = |${OBS_DIR}|"
 #echo "ACCUM_HH = |${ACCUM_HH}|"
 #kjkjkjkjkj
 
-#FIELDNAME_IN_OBS_INPUT=""
-#FIELDNAME_IN_FCST_INPUT=""
-#FIELDNAME_IN_MET_OUTPUT=""
 FIELDNAME_IN_MET_FILEDIR_NAMES=""
 
 echo
@@ -108,9 +105,6 @@ if [ $(boolify "${VX_VERIFY_AGAINST_BENCHMARK_FCST}") = "TRUE" ]; then
 
   OBTYPE="${VX_BENCHMARK_FCST_MODEL_NAME}"
   grid_or_point="grid"
-#  FIELDNAME_IN_OBS_INPUT=""
-#  FIELDNAME_IN_FCST_INPUT=""
-#  FIELDNAME_IN_MET_OUTPUT=""
   FIELDNAME_IN_MET_FILEDIR_NAMES="${VX_BENCHMARK_FCST_MODEL_NAME}"
 
 else
@@ -145,12 +139,7 @@ else
     outvarname_grid_or_point="grid_or_point" \
     outvarname_fieldname_in_MET_filedir_names="FIELDNAME_IN_MET_FILEDIR_NAMES"
 
-#    outvarname_fieldname_in_obs_input="FIELDNAME_IN_OBS_INPUT" \
-#    outvarname_fieldname_in_fcst_input="FIELDNAME_IN_FCST_INPUT" \
-#    outvarname_fieldname_in_MET_output="FIELDNAME_IN_MET_OUTPUT" \
-
 fi
-
 #
 #-----------------------------------------------------------------------
 #
@@ -466,10 +455,6 @@ settings="\
 ${vx_config_dict:-}
 "
 
-#'fieldname_in_obs_input': '${FIELDNAME_IN_OBS_INPUT}'
-#'fieldname_in_fcst_input': '${FIELDNAME_IN_FCST_INPUT}'
-#'fieldname_in_met_output': '${FIELDNAME_IN_MET_OUTPUT}'
-
 # Render the template to create a METplus configuration file
 tmpfile=$( $READLINK -f "$(mktemp ./met_plus_settings.XXXXXX.yaml)")
 printf "%s" "$settings" > "$tmpfile"

diff --git a/scripts/exregional_run_met_gridstat_or_pointstat_vx_ensmean.sh b/scripts/exregional_run_met_gridstat_or_pointstat_vx_ensmean.sh
@@ -89,9 +89,6 @@ CDATE="${PDY}${cyc}"
 #
 #-----------------------------------------------------------------------
 #
-#FIELDNAME_IN_OBS_INPUT=""
-#FIELDNAME_IN_FCST_INPUT=""
-#FIELDNAME_IN_MET_OUTPUT=""
 FIELDNAME_IN_MET_FILEDIR_NAMES=""
 
 set_vx_params \
@@ -100,10 +97,6 @@ set_vx_params \
   accum_hh="${ACCUM_HH}" \
   outvarname_grid_or_point="grid_or_point" \
   outvarname_fieldname_in_MET_filedir_names="FIELDNAME_IN_MET_FILEDIR_NAMES"
-
-#  outvarname_fieldname_in_obs_input="FIELDNAME_IN_OBS_INPUT" \
-#  outvarname_fieldname_in_fcst_input="FIELDNAME_IN_FCST_INPUT" \
-#  outvarname_fieldname_in_MET_output="FIELDNAME_IN_MET_OUTPUT" \
 #
 #-----------------------------------------------------------------------
 #
@@ -338,10 +331,6 @@ settings="\
 ${vx_config_dict:-}
 "
 
-#'fieldname_in_obs_input': '${FIELDNAME_IN_OBS_INPUT}'
-#'fieldname_in_fcst_input': '${FIELDNAME_IN_FCST_INPUT}'
-#'fieldname_in_met_output': '${FIELDNAME_IN_MET_OUTPUT}'
-
 # Render the template to create a METplus configuration file
 tmpfile=$( $READLINK -f "$(mktemp ./met_plus_settings.XXXXXX.yaml)")
 printf "%s" "$settings" > "$tmpfile"

diff --git a/scripts/exregional_run_met_gridstat_or_pointstat_vx_ensprob.sh b/scripts/exregional_run_met_gridstat_or_pointstat_vx_ensprob.sh
@@ -90,9 +90,6 @@ CDATE="${PDY}${cyc}"
 #
 #-----------------------------------------------------------------------
 #
-#FIELDNAME_IN_OBS_INPUT=""
-#FIELDNAME_IN_FCST_INPUT=""
-#FIELDNAME_IN_MET_OUTPUT=""
 FIELDNAME_IN_MET_FILEDIR_NAMES=""
 
 set_vx_params \
@@ -101,10 +98,6 @@ set_vx_params \
   accum_hh="${ACCUM_HH}" \
   outvarname_grid_or_point="grid_or_point" \
   outvarname_fieldname_in_MET_filedir_names="FIELDNAME_IN_MET_FILEDIR_NAMES"
-
-#  outvarname_fieldname_in_obs_input="FIELDNAME_IN_OBS_INPUT" \
-#  outvarname_fieldname_in_fcst_input="FIELDNAME_IN_FCST_INPUT" \
-#  outvarname_fieldname_in_MET_output="FIELDNAME_IN_MET_OUTPUT" \
 #
 #-----------------------------------------------------------------------
 #
@@ -338,10 +331,6 @@ settings="\
 ${vx_config_dict:-}
 "
 
-#'fieldname_in_obs_input': '${FIELDNAME_IN_OBS_INPUT}'
-#'fieldname_in_fcst_input': '${FIELDNAME_IN_FCST_INPUT}'
-#'fieldname_in_met_output': '${FIELDNAME_IN_MET_OUTPUT}'
-
 # Render the template to create a METplus configuration file
 tmpfile=$( $READLINK -f "$(mktemp ./met_plus_settings.XXXXXX.yaml)")
 printf "%s" "$settings" > "$tmpfile"

diff --git a/scripts/exregional_run_met_pb2nc_obs.sh b/scripts/exregional_run_met_pb2nc_obs.sh
@@ -111,9 +111,6 @@ CDATE="${PDY}${cyc}"
 #
 #-----------------------------------------------------------------------
 #
-#FIELDNAME_IN_OBS_INPUT=""
-#FIELDNAME_IN_FCST_INPUT=""
-#FIELDNAME_IN_MET_OUTPUT=""
 FIELDNAME_IN_MET_FILEDIR_NAMES=""
 
 set_vx_params \
@@ -122,10 +119,6 @@ set_vx_params \
   accum_hh="${ACCUM_HH}" \
   outvarname_grid_or_point="grid_or_point" \
   outvarname_fieldname_in_MET_filedir_names="FIELDNAME_IN_MET_FILEDIR_NAMES"
-
-#  outvarname_fieldname_in_obs_input="FIELDNAME_IN_OBS_INPUT" \
-#  outvarname_fieldname_in_fcst_input="FIELDNAME_IN_FCST_INPUT" \
-#  outvarname_fieldname_in_MET_output="FIELDNAME_IN_MET_OUTPUT" \
 #
 #-----------------------------------------------------------------------
 #
@@ -344,10 +337,6 @@ settings="\
   'accum_no_pad': '${ACCUM_NO_PAD:-}'
 "
 
-#  'fieldname_in_obs_input': '${FIELDNAME_IN_OBS_INPUT}'
-#  'fieldname_in_fcst_input': '${FIELDNAME_IN_FCST_INPUT}'
-#  'fieldname_in_met_output': '${FIELDNAME_IN_MET_OUTPUT}'
-
 # Render the template to create a METplus configuration file
 tmpfile=$( $READLINK -f "$(mktemp ./met_plus_settings.XXXXXX.yaml)")
 printf "%s" "$settings" > "$tmpfile"

diff --git a/scripts/exregional_run_met_pcpcombine.sh b/scripts/exregional_run_met_pcpcombine.sh
@@ -91,9 +91,6 @@ CDATE="${PDY}${cyc}"
 #
 #-----------------------------------------------------------------------
 #
-#FIELDNAME_IN_OBS_INPUT=""
-#FIELDNAME_IN_FCST_INPUT=""
-#FIELDNAME_IN_MET_OUTPUT=""
 FIELDNAME_IN_MET_FILEDIR_NAMES=""
 
 set_vx_params \
@@ -102,10 +99,6 @@ set_vx_params \
   accum_hh="${ACCUM_HH}" \
   outvarname_grid_or_point="grid_or_point" \
   outvarname_fieldname_in_MET_filedir_names="FIELDNAME_IN_MET_FILEDIR_NAMES"
-
-#  outvarname_fieldname_in_obs_input="FIELDNAME_IN_OBS_INPUT" \
-#  outvarname_fieldname_in_fcst_input="FIELDNAME_IN_FCST_INPUT" \
-#  outvarname_fieldname_in_MET_output="FIELDNAME_IN_MET_OUTPUT" \
 #
 #-----------------------------------------------------------------------
 #
@@ -397,10 +390,6 @@ settings="\
   'input_thresh_fcst': '${FCST_THRESH:-}'
 "
 
-#  'fieldname_in_obs_input': '${FIELDNAME_IN_OBS_INPUT}'
-#  'fieldname_in_fcst_input': '${FIELDNAME_IN_FCST_INPUT}'
-#  'fieldname_in_met_output': '${FIELDNAME_IN_MET_OUTPUT}'
-
 # Render the template to create a METplus configuration file
 tmpfile=$( $READLINK -f "$(mktemp ./met_plus_settings.XXXXXX.yaml)")
 printf "%s" "$settings" > "$tmpfile"

diff --git a/ush/set_vx_params.sh b/ush/set_vx_params.sh
@@ -60,9 +60,6 @@ function set_vx_params() {
         "outvarname_grid_or_point" \
         "outvarname_fieldname_in_MET_filedir_names" \
         )
-#        "outvarname_fieldname_in_obs_input" \
-#        "outvarname_fieldname_in_fcst_input" \
-#        "outvarname_fieldname_in_MET_output" \
   process_args valid_args "$@"
 #
 #-----------------------------------------------------------------------
@@ -83,9 +80,6 @@ function set_vx_params() {
 #
   local _grid_or_point_ \
         fieldname_in_MET_filedir_names
-#        fieldname_in_obs_input \
-#        fieldname_in_fcst_input \
-#        fieldname_in_MET_output \
 #
 #-----------------------------------------------------------------------
 #
@@ -111,20 +105,6 @@ be a 2-digit integer:
 # String that is set to either "grid" or "point" depending on whether
 # obs type containing the field group is gridded or point-based.
 #
-## fieldname_in_obs_input:
-## If the field group represents a single field, this is the string used
-## to search for that field in the input observation files read in by MET.
-## If not, this is set to a null string.
-##
-## fieldname_in_fcst_input:
-## If the field group represents a single field, this is the string used
-## to search for that field in the input forecast files read in by MET.
-## If not, this is set to a null string.
-##
-## fieldname_in_MET_output:
-## String that will be used in naming arrays defined in MET output files
-## (e.g. NetCDF, stat, etc).
-##
 # fieldname_in_MET_filedir_names:
 # String that will be used in naming directories and files (e.g. NetCDF
 # files, stat files, log files, staging directories) generated by MET
@@ -133,9 +113,6 @@ be a 2-digit integer:
 #-----------------------------------------------------------------------
 #
   _grid_or_point_=""
-#  fieldname_in_obs_input=""
-#  fieldname_in_fcst_input=""
-#  fieldname_in_MET_output=""
   fieldname_in_MET_filedir_names=""
 
   case "${obtype}" in
@@ -146,9 +123,6 @@ be a 2-digit integer:
       case "${field_group}" in
 
         "APCP")
-#          fieldname_in_obs_input="${field_group}"
-#          fieldname_in_fcst_input="${field_group}"
-#          fieldname_in_MET_output="${field_group}"
           fieldname_in_MET_filedir_names="${field_group}${accum_hh}h"
           ;;
 
@@ -169,9 +143,6 @@ this observation type (obtype) and field group (field_group) combination:
       case "${field_group}" in
 
         "ASNOW")
-#          fieldname_in_obs_input="${field_group}"
-#          fieldname_in_fcst_input="${field_group}"
-#          fieldname_in_MET_output="${field_group}"
           fieldname_in_MET_filedir_names="${field_group}${accum_hh}h"
           ;;
 
@@ -192,16 +163,10 @@ this observation type (obtype) and field group (field_group) combination:
       case "${field_group}" in
 
         "REFC")
-#          fieldname_in_obs_input="MergedReflectivityQCComposite"
-#          fieldname_in_fcst_input="${field_group}"
-#          fieldname_in_MET_output="${field_group}"
           fieldname_in_MET_filedir_names="${field_group}"
           ;;
 
         "RETOP")
-#          fieldname_in_obs_input="EchoTop18"
-#          fieldname_in_fcst_input="${field_group}"
-#          fieldname_in_MET_output="${field_group}"
           fieldname_in_MET_filedir_names="${field_group}"
           ;;
 
@@ -210,16 +175,10 @@ this observation type (obtype) and field group (field_group) combination:
 # bigger fix is necessary.
 
         "SFC")
-#          fieldname_in_obs_input=""
-#          fieldname_in_fcst_input=""
-#          fieldname_in_MET_output="ADP${field_group}"
           fieldname_in_MET_filedir_names="ADP${field_group}"
           ;;
 
         "UPA")
-#          fieldname_in_obs_input=""
-#          fieldname_in_fcst_input=""
-#          fieldname_in_MET_output="ADP${field_group}"
           fieldname_in_MET_filedir_names="ADP${field_group}"
           ;;
 
@@ -241,16 +200,10 @@ this observation type (obtype) and field group (field_group) combination:
       case "${field_group}" in
 
         "SFC")
-#          fieldname_in_obs_input=""
-#          fieldname_in_fcst_input=""
-#          fieldname_in_MET_output="ADP${field_group}"
           fieldname_in_MET_filedir_names="ADP${field_group}"
           ;;
 
         "UPA")
-#          fieldname_in_obs_input=""
-#          fieldname_in_fcst_input=""
-#          fieldname_in_MET_output="ADP${field_group}"
           fieldname_in_MET_filedir_names="ADP${field_group}"
           ;;
 
@@ -284,18 +237,6 @@ this observation type (obtype):
     printf -v ${outvarname_grid_or_point} "%s" "${_grid_or_point_}"
   fi
 
-#  if [ ! -z "${outvarname_fieldname_in_obs_input}" ]; then
-#    printf -v ${outvarname_fieldname_in_obs_input} "%s" "${fieldname_in_obs_input}"
-#  fi
-#
-#  if [ ! -z "${outvarname_fieldname_in_fcst_input}" ]; then
-#    printf -v ${outvarname_fieldname_in_fcst_input} "%s" "${fieldname_in_fcst_input}"
-#  fi
-#
-#  if [ ! -z "${outvarname_fieldname_in_MET_output}" ]; then
-#    printf -v ${outvarname_fieldname_in_MET_output} "%s" "${fieldname_in_MET_output}"
-#  fi
-
   if [ ! -z "${outvarname_fieldname_in_MET_filedir_names}" ]; then
     printf -v ${outvarname_fieldname_in_MET_filedir_names} "%s" "${fieldname_in_MET_filedir_names}"
   fi