General QA

gsteel · Feb 24, 2025 · ccdc52c · ccdc52c
1 parent 989e277
commit ccdc52c
Show file tree

Hide file tree

Showing 29 changed files with 137 additions and 73 deletions.
diff --git a/composer.json b/composer.json
@@ -37,9 +37,9 @@
         "fig/http-message-util": "^1.1.5",
         "gsteel/dot": "^1.8",
         "laminas/laminas-cli": "^1.11",
-        "laminas/laminas-config-aggregator": "^1.17",
+        "laminas/laminas-config-aggregator": "^1.18",
         "laminas/laminas-diactoros": "^3.5.0",
-        "laminas/laminas-escaper": "^2.15",
+        "laminas/laminas-escaper": "^2.16",
         "laminas/laminas-filter": "^2.40.0",
         "laminas/laminas-form": "^3.21.0",
         "laminas/laminas-i18n": "^2.29",

diff --git a/composer.lock b/composer.lock
diff --git a/phpcs.xml b/phpcs.xml
@@ -5,15 +5,21 @@
     <arg name="parallel" value="80"/>
     <arg name="cache" value="data/cache/.php_cs.cache"/>
     <arg name="colors"/>
-    <arg value="nps" />
+    <arg value="ps" />
 
     <!-- Paths to check -->
     <file>config</file>
     <file>src</file>
     <file>test</file>
 
     <!-- Inherit rules from Doctrine Coding Standard -->
-    <rule ref="Doctrine" />
+    <rule ref="Doctrine">
+        <!-- Disable deprecated sniff -->
+        <exclude name="SlevomatCodingStandard.TypeHints.UnionTypeHintFormat" />
+    </rule>
+
+    <!-- Replacement Rule for UnionTypeHintFormat -->
+    <rule ref="SlevomatCodingStandard.TypeHints.DNFTypeHintFormat" />
 
     <rule ref="Generic.Formatting.MultipleStatementAlignment.NotSame">
         <severity>0</severity>

diff --git a/src/App/BaseRate/ChangeList.php b/src/App/BaseRate/ChangeList.php
@@ -11,6 +11,7 @@
 use DateTimeInterface;
 use IteratorAggregate;
 use JsonSerializable;
+use Override;
 use Traversable;
 
 use function array_reverse;
@@ -61,18 +62,21 @@ public function findChangeOnOrPreceding(DateTimeInterface $date): RateChange|nul
     }
 
     /** @return Traversable<array-key, RateChange> */
+    #[Override]
     public function getIterator(): Traversable
     {
         return new ArrayIterator($this->rates);
     }
 
     /** @psalm-suppress PossiblyUnusedMethod */
+    #[Override]
     public function count(): int
     {
         return count($this->rates);
     }
 
     /** @return list<RateChange> */
+    #[Override]
     public function jsonSerialize(): array
     {
         return $this->rates;