Populate individual sections with titles and prerequisites as needed #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeluro1
changed the title
yatharth-b
reviewed
Feb 20, 2024
There was a problem hiding this comment.
Love the changes so far! Suggested some structural changes which are just opinions on what the backend vs frontend should do + having uniformity in what we crawl.
Suggestions for new Course and Section types just to re-iterate :
export type Section = [
crn: string,
meetings: Meeting[],
creditHours: number,
scheduleTypeIndex: number,
campusIndex: number,
attributeIndices: number[],
gradeBaseIndex: number,
fullName: string,
prerequisites: Prerequisites
];
export type Course = [
fullName: string,
sections: Record<string, Section>,
description: string | null
];
yatharth-b
reviewed
Mar 4, 2024
src/steps/parse.ts
Outdated
|
|
||
| // Store course ID with section number to obtain prerequisites for all sections | ||
| // These sections will be stored as pseudo-courses with CRNs included for prerequisite attaching | ||
| sectionCrns.push(`${courseName} <${courseReferenceNumber}>`); |
There was a problem hiding this comment.
Thanks for the changes. Can you instead create objects here which store the courseName and courseReferenceNumber. We wouldn't need to parse this string in downloadPrereqs either then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves gt-scheduler/website#267