Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare Panel #185

Merged
merged 21 commits into from
Oct 19, 2023
Merged

Compare Panel #185

merged 21 commits into from
Oct 19, 2023

Conversation

sophiazlin
Copy link
Contributor

@sophiazlin sophiazlin commented Mar 1, 2023

Summary

Resolves #175

Adds compare panel and related overlays and modals.
There is a bug with the drawer button. If you move your mouse really fast left and right over it, it causes the tooltip to appear at (0, 0).

Checklist

Acceptance Criteria

UI Requirements

  • A new panel is added on the right side of the screen that houses CombinationContainer and the new component ComparisonContainer.
  • The new panel is collapsible and should behave like a drawer.
  • The ComparisonContainer has a header with an enable button
  • Friends' and schedules' names are editable.
  • When a friend has a nickname, hovering over the nickname should display a popup with their email info.
  • Friends and schedules can be deleted and a confirmation modal should pop up to confirm the deletion.
  • Panel works for both light and dark modes.

How to Test

Run the code and go through all functions (click checkboxes, edit schedules, delete schedules, add schedule versions (through the form in the version dropdown), etc.)

@sophiazlin sophiazlin requested a review from nhatnghiho March 1, 2023 00:40
@github-actions
Copy link

github-actions bot commented Mar 4, 2023

PR Preview Action v1.4.4
🚀 Deployed preview to https://gt-scheduler.github.io/website/pr-preview/pr-185/
on branch gh-pages at 2023-10-19 18:09 UTC

src/components/ComparisonContainer/index.tsx Outdated Show resolved Hide resolved
src/components/ComparisonContainer/index.tsx Outdated Show resolved Hide resolved
src/components/ComparisonContainer/index.tsx Outdated Show resolved Hide resolved
src/components/ComparisonContainer/index.tsx Outdated Show resolved Hide resolved
@nhatnghiho
Copy link
Contributor

Looks good overall! We got some small design changes over the past week which includes

  • Collapsing the list of comparable schedules when "Compare Schedules" is off.
    image
  • Displaying a text popup telling user that they have to disable compare mode to edit their own schedules
    image
  • Allowing users to choose the display colors of their friends' schedules

image

Hopefully these won't take too much time for you. Lmk if you need more time though!

@yatharth-b
Copy link
Contributor

yatharth-b commented Apr 8, 2023

UI looks super clean! Only thing I noticed was that the enable switch styling didn't match the figma in dark mode.

Figma:
image

Website:
image

@samarth52 samarth52 changed the base branch from bog-changes-s23 to bog-changes-s23-merged October 19, 2023 17:54
@samarth52 samarth52 merged commit fdf35fe into bog-changes-s23-merged Oct 19, 2023
3 checks passed
@samarth52 samarth52 deleted the sophia/175-compare-panel branch October 19, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants