-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Functionality to Invitation Modal #186
base: bog-changes-s23
Are you sure you want to change the base?
Add Functionality to Invitation Modal #186
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To fix failing CI tests, run yarn test
to see which tests are failing and fix them accordingly. Most of these are just because we're adding a new field into ScheduleVersion
and some expected values in unit tests do not have this new field yet.
If we're not doing autocomplete anymore, could you remove the code for that? On top of that, allow users to send invitation by pressing |
Summary
Resolves #173
Users can now send invitations to friends from the share schedule popup. Added new variables to ScheduleContext to update and read friend data. Added checks to make sure only signed in users can open popup. Update cloud functions (gt-scheduler/firebase-conf#3) to alter create and handle invitation behavior. Fixed cloud functions to account for requests made from both fetch and axios.
Checklist
ScheduleData
is updated to include the list of invited friends and the status of the invitation.migrateScheduleData
must be updated along with any related tests.How to Test
Run firebase cloud function emulator from the firebase-conf repository and then try inviting users from the frontend. The cloud function links are hardcoded right now to be the local emulator links.
Note
Did not implement recently invited friends feature yet because of the backend overhead.