-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hyperlink to oscar when seats button clicked #222
base: main
Are you sure you want to change the base?
Conversation
const infoAction = { | ||
icon: faInfoCircle, | ||
href: | ||
`https://oscar.gatech.edu/pls/bprod/bwckctlg.p_disp_` + | ||
`course_detail?cat_term_in=${course.term}&subj_code_in=` + | ||
`${course.subject}&crse_numb_in=${course.number}`, | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be added back in to the actions
prop of the <ActionRow>
component.
This seems to look pretty nice (adding infoAction
after prereqAction
):
actions={
isSearching
? [{ icon: faPlus, onClick: onAddCourse }, prereqAction]
: [
{
icon: expanded ? faAngleUp : faAngleDown,
onClick: (): void => prereqControl(false, !expanded),
},
prereqAction,
infoAction,
{
icon: faPalette,
onClick: (): void => setPaletteShown(!paletteShown),
},
...
This results in:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense, thank you!
A couple small changes are needed to make the PR pass CI (see the failures here). I left comments on each, they should be fairly minor. |
Co-authored-by: Joseph Azevedo <[email protected]>
Co-authored-by: Joseph Azevedo <[email protected]>
Thanks for working on this issue @EBruda (and for reviewing too @jazeved0)! We actually deliberately removed the hyperlink to Oscar when we migrated GT Scheduler's crawler to the new registration system. This is because we received intel from OIT that Banner 8, the software that powers the old Oscar, will reach its end of life soon. As a result, the |
Summary
Updated the hyperlinks (see #220)
How to Test
Run gt-scheduler locally and add a class section. Then, click on the seats button for each section. Ensure that the OSCAR tab opened has the correct term and the class section matches the one in gt-scheduler.