Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regen with latest gir/gir-files #1285

Merged
merged 13 commits into from
Jan 25, 2024
Merged

Regen with latest gir/gir-files #1285

merged 13 commits into from
Jan 25, 2024

Conversation

bilelmoussaoui
Copy link
Member

Not finished yet, but opened for checking the CI & tracking the types that lack a since annotation

gio/src/auto/enums.rs Show resolved Hide resolved
gio/src/auto/enums.rs Outdated Show resolved Hide resolved
gio/src/auto/flags.rs Show resolved Hide resolved
gio/src/auto/resolver.rs Outdated Show resolved Hide resolved
gio/sys/Cargo.toml Show resolved Hide resolved
glib/gobject-sys/Cargo.toml Show resolved Hide resolved
glib/src/auto/enums.rs Outdated Show resolved Hide resolved
glib/src/auto/enums.rs Show resolved Hide resolved
glib/src/auto/functions.rs Outdated Show resolved Hide resolved
glib/sys/Cargo.toml Show resolved Hide resolved
glib/sys/src/lib.rs Outdated Show resolved Hide resolved
glib/sys/src/lib.rs Show resolved Hide resolved
glib/sys/src/lib.rs Show resolved Hide resolved
glib/sys/src/lib.rs Outdated Show resolved Hide resolved
glib/src/auto/functions.rs Outdated Show resolved Hide resolved
glib/src/auto/functions.rs Outdated Show resolved Hide resolved
glib/src/auto/functions.rs Outdated Show resolved Hide resolved
glib/src/auto/functions.rs Outdated Show resolved Hide resolved
glib/src/auto/functions.rs Outdated Show resolved Hide resolved
glib/src/auto/functions.rs Outdated Show resolved Hide resolved
@pbor pbor force-pushed the bilelmoussaoui/regen-2 branch from 19b6f74 to e5e18c4 Compare January 20, 2024 11:24
@bilelmoussaoui bilelmoussaoui force-pushed the bilelmoussaoui/regen-2 branch 5 times, most recently from 4d96669 to 49e90b6 Compare January 20, 2024 15:00
@bilelmoussaoui
Copy link
Member Author

GLib's sys tests are failing with


tests/layout.c: In function 'main':
tests/layout.c:117:48: error: 'GUnixPipe' undeclared (first use in this function)
  117 |     printf("%s;%zu;%zu\n", "GUnixPipe", sizeof(GUnixPipe), alignof(GUnixPipe));
      |                                                ^~~~~~~~~
tests/layout.c:117:48: note: each undeclared identifier is reported only once for each function it appears in
tests/layout.c:118:51: error: 'GUnixPipeEnd' undeclared (first use in this function)
  118 |     printf("%s;%zu;%zu\n", "GUnixPipeEnd", sizeof(GUnixPipeEnd), alignof(GUnixPipeEnd));
      |                                                   ^~~~~~~~~~~~
tests/layout.c:130:51: error: 'GWin32OSType' undeclared (first use in this function)
  130 |     printf("%s;%zu;%zu\n", "GWin32OSType", sizeof(GWin32OSType), alignof(GWin32OSType));
      |                                                   ^~~~~~~~~~~~
test cross_validate_layout_with_c ... FAILED
tests/constant.c: In function 'main':
tests/constant.c:520:20: error: 'G_TRACE_CURRENT_TIME' undeclared (first use in this function)
  520 |     PRINT_CONSTANT(G_TRACE_CURRENT_TIME);
      |                    ^~~~~~~~~~~~~~~~~~~~
tests/constant.c:10:22: note: in definition of macro 'PRINT_CONSTANT'
   10 |     printf(_Generic((CONSTANT_NAME), \
      |                      ^~~~~~~~~~~~~
tests/constant.c:520:20: note: each undeclared identifier is reported only once for each function it appears in
  520 |     PRINT_CONSTANT(G_TRACE_CURRENT_TIME);
      |                    ^~~~~~~~~~~~~~~~~~~~
tests/constant.c:10:22: note: in definition of macro 'PRINT_CONSTANT'
   10 |     printf(_Generic((CONSTANT_NAME), \
      |                      ^~~~~~~~~~~~~
tests/constant.c:773:27: error: 'G_UNIX_PIPE_END_READ' undeclared (first use in this function)
  773 |     PRINT_CONSTANT((gint) G_UNIX_PIPE_END_READ);
      |                           ^~~~~~~~~~~~~~~~~~~~
tests/constant.c:10:22: note: in definition of macro 'PRINT_CONSTANT'
   10 |     printf(_Generic((CONSTANT_NAME), \
      |                      ^~~~~~~~~~~~~
tests/constant.c:774:27: error: 'G_UNIX_PIPE_END_WRITE' undeclared (first use in this function)
  774 |     PRINT_CONSTANT((gint) G_UNIX_PIPE_END_WRITE);
      |                           ^~~~~~~~~~~~~~~~~~~~~
tests/constant.c:10:22: note: in definition of macro 'PRINT_CONSTANT'
   10 |     printf(_Generic((CONSTANT_NAME), \
      |                      ^~~~~~~~~~~~~
tests/constant.c:855:27: error: 'G_WIN32_OS_ANY' undeclared (first use in this function); did you mean 'G_WIN32_MSG_HANDLE'?
  855 |     PRINT_CONSTANT((gint) G_WIN32_OS_ANY);
      |                           ^~~~~~~~~~~~~~
tests/constant.c:10:22: note: in definition of macro 'PRINT_CONSTANT'
   10 |     printf(_Generic((CONSTANT_NAME), \
      |                      ^~~~~~~~~~~~~
tests/constant.c:856:27: error: 'G_WIN32_OS_SERVER' undeclared (first use in this function)
  856 |     PRINT_CONSTANT((gint) G_WIN32_OS_SERVER);
      |                           ^~~~~~~~~~~~~~~~~
tests/constant.c:10:22: note: in definition of macro 'PRINT_CONSTANT'
   10 |     printf(_Generic((CONSTANT_NAME), \
      |                      ^~~~~~~~~~~~~
tests/constant.c:857:27: error: 'G_WIN32_OS_WORKSTATION' undeclared (first use in this function)
  857 |     PRINT_CONSTANT((gint) G_WIN32_OS_WORKSTATION);
      |                           ^~~~~~~~~~~~~~~~~~~~~~
tests/constant.c:10:22: note: in definition of macro 'PRINT_CONSTANT'
   10 |     printf(_Generic((CONSTANT_NAME), \
      |                      ^~~~~~~~~~~~~
test cross_validate_constants_with_c ... FAILED

failures:

---- cross_validate_layout_with_c stdout ----
thread 'cross_validate_layout_with_c' panicked at glib/sys/tests/abi.rs:154:37:
called `Result::unwrap()` on an `Err` value: "compilation command \"cc\" \"-Wno-deprecated-declarations\" \"-std=c11\" \"-D__USE_MINGW_ANSI_STDIO\" \"-I/usr/include/glib-2.0\" \"-I/usr/lib64/glib-2.0/include\" \"tests/layout.c\" \"-o\" \"/tmp/abirrZqJp/layout\" failed, exit status: 1"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- cross_validate_constants_with_c stdout ----
thread 'cross_validate_constants_with_c' panicked at glib/sys/tests/abi.rs:120:39:
called `Result::unwrap()` on an `Err` value: "compilation command \"cc\" \"-Wno-deprecated-declarations\" \"-std=c11\" \"-D__USE_MINGW_ANSI_STDIO\" \"-I/usr/include/glib-2.0\" \"-I/usr/lib64/glib-2.0/include\" \"tests/constant.c\" \"-o\" \"/tmp/abiR73fU2/constant\" failed, exit status: 1"

so i have disabled them for now; we should try to get them fixed later but they require some kind of split between unix/windows specific tests...

gio/Gir.toml Show resolved Hide resolved
glib/src/auto/functions.rs Outdated Show resolved Hide resolved
glib/src/auto/functions.rs Outdated Show resolved Hide resolved
glib/src/auto/functions.rs Outdated Show resolved Hide resolved
Copy link
Member

@sdroege sdroege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly ok, nice :) Good work!

@bilelmoussaoui
Copy link
Member Author

I am going to land this once the CI passes

@bilelmoussaoui bilelmoussaoui merged commit c7ef86e into master Jan 25, 2024
47 of 48 checks passed
@bilelmoussaoui bilelmoussaoui deleted the bilelmoussaoui/regen-2 branch January 25, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants