-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regen with latest gir/gir-files #1285
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bilelmoussaoui
commented
Jan 18, 2024
bilelmoussaoui
commented
Jan 18, 2024
bilelmoussaoui
commented
Jan 18, 2024
bilelmoussaoui
commented
Jan 18, 2024
bef2f66
to
dd971da
Compare
19b6f74
to
e5e18c4
Compare
4d96669
to
49e90b6
Compare
GLib's sys tests are failing with
so i have disabled them for now; we should try to get them fixed later but they require some kind of split between unix/windows specific tests... |
The commit will be removed once the new fixed gir file lands
It currently fails
49e90b6
to
b8d6a18
Compare
sdroege
reviewed
Jan 22, 2024
sdroege
reviewed
Jan 22, 2024
sdroege
reviewed
Jan 22, 2024
sdroege
reviewed
Jan 22, 2024
sdroege
reviewed
Jan 22, 2024
sdroege
reviewed
Jan 22, 2024
sdroege
reviewed
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly ok, nice :) Good work!
Those appeared recently and are not part of a new release so it causes various issues
Fixes the ffi tests
b8d6a18
to
17dcc90
Compare
I am going to land this once the CI passes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not finished yet, but opened for checking the CI & tracking the types that lack a since annotation