Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manually add typed and with_type methods #1386

Closed
wants to merge 1 commit into from

Conversation

ranfdev
Copy link
Member

@ranfdev ranfdev commented Apr 28, 2023

Closes #1384

I've also found DropTarget::new which could receive the same treatment, but that's a more complex case, because it can also accept the type G_TYPE_INVALID when the user wants to specify multiple GTypes, so I've just skipped that.

@ranfdev ranfdev requested a review from bilelmoussaoui as a code owner April 28, 2023 16:15
@jf2048
Copy link
Member

jf2048 commented Apr 28, 2023

Maybe it can be split into DropTarget::new, DropTarget::with_type and DropTarget::with_types?

@bilelmoussaoui
Copy link
Member

There are other ones as you can tell from the link i shared in the issue

@bilelmoussaoui
Copy link
Member

Please add a note to the changelog as well

bilelmoussaoui added a commit that referenced this pull request Jul 6, 2023
@bilelmoussaoui
Copy link
Member

Maybe it can be split into DropTarget::new, DropTarget::with_type and DropTarget::with_types?

That is what I ended up doing. It is a much better API :-)

Replaced by #1415

bilelmoussaoui added a commit that referenced this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New and with_type methods as in gtk-rs-core
3 participants