Add missing installation step for Windows #1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
book/src/installation_windows.md
Outdated
Comment on lines
43
to
50
| ### Ensure your linker can find GTK's library files | ||
|
|
||
| Open `%HOMEPATH%\.cargo\config` for editing. You can add extra flags for your linker here to tell it where GTK's library files are. If you're using LLVM's linker with the `stable-x86_64-pc-windows-msvc` Rust toolchain, your config may look like this: | ||
|
|
||
| ```toml | ||
| [target.x86_64-pc-windows-msvc] | ||
| linker = "lld-link.exe" | ||
| rustflags = ["-C", "link-args=/LIBPATH:C:\\gtk-build\\gtk\\x64\\release\\lib\\"] | ||
| ``` |
There was a problem hiding this comment.
I assume that's only necessary if you use lld?
If yes, please make that clear here
There was a problem hiding this comment.
You also need to use it when using the default linker, I just didn't research the appropriate flag to do so. Here's what happens when I remove my ~/.cargo/config:
error: linking with `link.exe` failed: exit code: 1181
(...)
= note: LINK : fatal error LNK1181: cannot open input file 'gobject-2.0.lib'
This works fine for me:
[target.x86_64-pc-windows-msvc]
rustflags = ["-C", "link-args=/LIBPATH:C:\\gtk-build\\gtk\\x64\\release\\lib\\"]It looks like both linkers support the same flag, so I'll update the documentation accordingly.
There was a problem hiding this comment.
I wonder why I didn't have to do that, but oh well.
Let's add it :)
Rewrite it a bit and document the linker configuration step.
pieterdd
force-pushed
the
expand-windows-install-instructions
branch
from
0666fd3 to
a1fe0db
Compare
Hofer-Julian
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially the instructions didn't work for me, but I was able to figure out that I was missing a bit of linker configuration. I documented this requirement and rewrote other parts of the Windows documentation a little bit.