This repository has been archived by the owner on Sep 1, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobwinch
added
enhancement
New feature or request
PR Deployment
and removed
enhancement
New feature or request
labels
Sep 11, 2020
jacobwinch
requested review from
JamieB-gu,
webb04,
dskamiotis,
faresite and
frankie297
September 11, 2020 08:21
webb04
approved these changes
Sep 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
Is this time the creation time rather than the expiry? "This PR is now live until Fri 08:57. Click details to access it ->"
Or is it open for 12 hours?
Good catch @webb04 - we're adding an hour to the current time ( |
FYI @alexduf |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are you doing this?
This PR provides an easy mechanism for deploying a branch to a public URL. In the short-term this can be used for manually testing changes (either your own, or someone else's, as part of the code review process). Longer term, exposing a public URL for every PR allows us to easily run additional tasks/checks (e.g. taking screenshots, running performance tests etc.).
Thanks to @jorgeazevedo who did all of the hard work on this with Dotcom (see guardian/dotcom-rendering#1841) - I've borrowed liberally from his work here!
Whilst under development, this check won't (automatically) run against every PR - see
How will it work?
section for more details.Changes
How will it work?
Adding the
PR Deployment
label starts the new workflow*:Once the workflow has started the application, another status check will appear. This provides a link to the running environment:
The check will only run if the
PR Deployment
label is added to a PR. Adding any other label will produce a 'skipped' check:*Note that this workflow will keep running (and retain the yellow 'pending' dot) until the timeout is reached. Developers do not need to wait for this check to 'finish' before merging.