Migrate fabric-expandable template to Svelte #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visual regression testing results 🔍If any tests are failing, please check that any visual changes are intentional before merging your PR.
|
Jakeii
approved these changes
Jan 2, 2025
emma-imber
force-pushed
the
ei/fabric-expandable
branch
from
5cf22ae to
bbd7a54
Compare
Jakeii
reviewed
Jan 14, 2025
Jakeii
reviewed
Jan 14, 2025
Jakeii
approved these changes
Jan 14, 2025
Co-authored-by: Jake <[email protected]>
Co-authored-by: Jake <[email protected]>
emma-imber
force-pushed
the
ei/fabric-expandable
branch
from
99d6a70 to
f8b6b22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Migrates the Fabric expandable template to Svelte. This effectively consists of two Fabric 'slides' with the second slide being revealed when one of the buttons is clicked to expand the ad.
Ad test for the migrated template is currently live here: https://www.theguardian.com/uk/culture?adtest=fabric-expandable-migration
And this is the ad test for the legacy template for comparison: https://www.theguardian.com/uk/culture?adtest=GuardianTabloidDemos_FabricMiddleExpandable
Screen.Recording.2025-01-14.at.15.19.05.mov