Rationalise DCR's env checking scripts #9400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sndrs
force-pushed
the
sndrs/repo-scripts
branch
from
22b91c9
to
ed02a19
Compare
they don’t need to run every time you use the makefile
sndrs
force-pushed
the
sndrs/repo-scripts
branch
from
ed02a19
to
2af6b0e
Compare
|
Size Change: 0 B Total Size: 696 kB ℹ️ View Unchanged
|
sndrs
force-pushed
the
sndrs/repo-scripts
branch
from
2af6b0e
to
e183b80
Compare
sndrs
force-pushed
the
sndrs/repo-scripts
branch
from
e183b80
to
dd355bd
Compare
sndrs
changed the title
|
part of #9421 |
mxdvl
reviewed
Nov 7, 2023
|
|
||
| const __dirname = dirname(fileURLToPath(import.meta.url)); | ||
|
|
||
| process.chdir(resolve(__dirname, '..')); | ||
|
|
||
| const nvmrc = (await readFile('.nvmrc', 'utf-8')) | ||
| const nvmrc = (await readFile('../.nvmrc', 'utf-8')) |
There was a problem hiding this comment.
I’m not sure this should live inside dotcom-rendering as it’s looking for files in both workspaces and in the root.
There was a problem hiding this comment.
it's a DCR concern though right? it's looking in the root for the root version, and making sure that DCR-related files (which AR files are, really, i think?) are in sync with the repo more generally.
should it be the responsibility of the root to ensure that apps in the workspace stay in sync with the root?
There was a problem hiding this comment.
In my mind the root is a good place for scripts that span all workspaces, but I agree that it should be a workspace concern to stay in sync with the root.
I’ll defer to anyone in @guardian/dotcom-platform with a stronger or better articulated view.
There was a problem hiding this comment.
Merged, but if anyone prefers to move it, please do
mxdvl
approved these changes
Nov 7, 2023
and standardise the escape char
cemms1
added a commit
that referenced
this pull request
Nov 8, 2023
sndrs
added a commit
that referenced
this pull request
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
log,check-nodeandcheck-yarnscripts to the project rootcheck-node-versionsscript to DCRcheck-depsandcheck-filesto DCR's makefilelint-projecttargetensureThere are also the following changes to how they work:
logto output un-coloured messages outside of terminalscheck-nodeto a bash scriptcheck-yarncheck for any yarn, and recommends usingcorepack enableif none is availableWhy?
This is preparation work for updating and upgrading the way
yarnand the workspace is used in the repo.log,check-nodeandcheck-yarnare not DCR-specificcheck-node-versionsis DCR-specificcheck-nodecurrently runs in node, writing it as a bash script means it has no dependencies (e.g. node no longer comes with macOS).