Upgrade Yarn to v4 #9466

sndrs · 2023-11-13T17:51:56Z

What does this change?

upgrades Yarn from v1 to v4
adds AR to the yarn workspace
disables some linting checks in AR that this surfaced

Why?

closes #9421

Screenshot

Note

This is conclusion of a multi-quarter joint-effort with @joecowton1.

github-actions · 2023-11-13T18:04:29Z

Size Change: +1 B (0%)

Total Size: 694 kB

ℹ️ View Unchanged

Filename	Size	Change
`dotcom-rendering/dist/100.web.********************.js`	990 B	0 B
`dotcom-rendering/dist/1076.web.********************.js`	3.08 kB	0 B
`dotcom-rendering/dist/1121.web.********************.js`	2.58 kB	0 B
`dotcom-rendering/dist/1136.web.********************.js`	884 B	0 B
`dotcom-rendering/dist/1178.web.********************.js`	504 B	0 B
`dotcom-rendering/dist/1294.web.********************.js`	5.36 kB	0 B
`dotcom-rendering/dist/1406.web.********************.js`	5.09 kB	0 B
`dotcom-rendering/dist/1418.web.********************.js`	9.98 kB	0 B
`dotcom-rendering/dist/1465.web.********************.js`	3.32 kB	0 B
`dotcom-rendering/dist/1520.web.********************.js`	492 B	0 B
`dotcom-rendering/dist/1521.web.********************.js`	5.48 kB	0 B
`dotcom-rendering/dist/1659.web.********************.js`	518 B	0 B
`dotcom-rendering/dist/1714.web.********************.js`	3.5 kB	0 B
`dotcom-rendering/dist/1959.web.********************.js`	29.5 kB	0 B
`dotcom-rendering/dist/1987.web.********************.js`	3.12 kB	0 B
`dotcom-rendering/dist/2092.web.********************.js`	849 B	0 B
`dotcom-rendering/dist/2096.web.********************.js`	13 kB	0 B
`dotcom-rendering/dist/2186.web.********************.js`	916 B	0 B
`dotcom-rendering/dist/2323.web.********************.js`	3.88 kB	0 B
`dotcom-rendering/dist/2351.web.********************.js`	3.34 kB	0 B
`dotcom-rendering/dist/2394.web.********************.js`	4.96 kB	0 B
`dotcom-rendering/dist/2510.web.********************.js`	663 B	0 B
`dotcom-rendering/dist/2511.web.********************.js`	819 B	0 B
`dotcom-rendering/dist/254.web.********************.js`	638 B	0 B
`dotcom-rendering/dist/2546.web.********************.js`	3.72 kB	0 B
`dotcom-rendering/dist/2551.web.********************.js`	4.7 kB	0 B
`dotcom-rendering/dist/2879.web.********************.js`	910 B	0 B
`dotcom-rendering/dist/2919.web.********************.js`	900 B	0 B
`dotcom-rendering/dist/2923.web.********************.js`	720 B	0 B
`dotcom-rendering/dist/3030.web.********************.js`	957 B	0 B
`dotcom-rendering/dist/3111.web.********************.js`	590 B	0 B
`dotcom-rendering/dist/3146.web.********************.js`	6.53 kB	0 B
`dotcom-rendering/dist/3149.web.********************.js`	636 B	0 B
`dotcom-rendering/dist/3265.web.********************.js`	916 B	0 B
`dotcom-rendering/dist/3302.web.********************.js`	820 B	0 B
`dotcom-rendering/dist/3389.web.********************.js`	884 B	0 B
`dotcom-rendering/dist/374.web.********************.js`	5.11 kB	0 B
`dotcom-rendering/dist/3795.web.********************.js`	797 B	0 B
`dotcom-rendering/dist/3968.web.********************.js`	3.79 kB	0 B
`dotcom-rendering/dist/4012.web.********************.js`	783 B	0 B
`dotcom-rendering/dist/4349.web.********************.js`	775 B	0 B
`dotcom-rendering/dist/4591.web.********************.js`	404 B	0 B
`dotcom-rendering/dist/4593.web.********************.js`	1.74 kB	0 B
`dotcom-rendering/dist/4627.web.********************.js`	783 B	0 B
`dotcom-rendering/dist/4797.web.********************.js`	744 B	0 B
`dotcom-rendering/dist/480.web.********************.js`	524 B	0 B
`dotcom-rendering/dist/489.web.********************.js`	5.21 kB	0 B
`dotcom-rendering/dist/5113.web.********************.js`	2.77 kB	0 B
`dotcom-rendering/dist/5225.web.********************.js`	6.67 kB	0 B
`dotcom-rendering/dist/5332.web.********************.js`	820 B	0 B
`dotcom-rendering/dist/5495.web.********************.js`	676 B	0 B
`dotcom-rendering/dist/5688.web.********************.js`	3.79 kB	0 B
`dotcom-rendering/dist/5744.web.********************.js`	720 B	0 B
`dotcom-rendering/dist/6068.web.********************.js`	775 B	0 B
`dotcom-rendering/dist/6126.web.********************.js`	2.23 kB	0 B
`dotcom-rendering/dist/6295.web.********************.js`	999 B	0 B
`dotcom-rendering/dist/639.web.********************.js`	951 B	0 B
`dotcom-rendering/dist/6428.web.********************.js`	741 B	0 B
`dotcom-rendering/dist/6442.web.********************.js`	2.77 kB	0 B
`dotcom-rendering/dist/657.web.********************.js`	2.46 kB	0 B
`dotcom-rendering/dist/6609.web.********************.js`	872 B	0 B
`dotcom-rendering/dist/6708.web.********************.js`	3.34 kB	0 B
`dotcom-rendering/dist/6967.web.********************.js`	850 B	0 B
`dotcom-rendering/dist/7569.web.********************.js`	4.87 kB	0 B
`dotcom-rendering/dist/7650.web.********************.js`	23 kB	0 B
`dotcom-rendering/dist/7701.web.********************.js`	647 B	0 B
`dotcom-rendering/dist/8085.web.********************.js`	2.59 kB	0 B
`dotcom-rendering/dist/8112.web.********************.js`	3.37 kB	0 B
`dotcom-rendering/dist/818.web.********************.js`	2.85 kB	0 B
`dotcom-rendering/dist/8268.web.********************.js`	4.75 kB	0 B
`dotcom-rendering/dist/8395.web.********************.js`	580 B	0 B
`dotcom-rendering/dist/8401.web.********************.js`	922 B	0 B
`dotcom-rendering/dist/8414.web.********************.js`	4.91 kB	0 B
`dotcom-rendering/dist/9196.web.********************.js`	784 B	0 B
`dotcom-rendering/dist/9251.web.********************.js`	2.22 kB	0 B
`dotcom-rendering/dist/9390.web.********************.js`	743 B	0 B
`dotcom-rendering/dist/9422.web.********************.js`	614 B	0 B
`dotcom-rendering/dist/9581.web.********************.js`	797 B	0 B
`dotcom-rendering/dist/9582.web.********************.js`	710 B	0 B
`dotcom-rendering/dist/9597.web.********************.js`	3.25 kB	0 B
`dotcom-rendering/dist/9617.web.********************.js`	1 kB	0 B
`dotcom-rendering/dist/9724.web.********************.js`	5.01 kB	0 B
`dotcom-rendering/dist/AdPortals-importable.web.********************.js`	3.6 kB	0 B
`dotcom-rendering/dist/AlreadyVisited-importable.web.********************.js`	412 B	0 B
`dotcom-rendering/dist/AppEmailSignUp-importable.web.********************.js`	7.21 kB	0 B
`dotcom-rendering/dist/AppsEpic-importable.web.********************.js`	3.97 kB	0 B
`dotcom-rendering/dist/AppsFooter-importable.web.********************.js`	3.25 kB	0 B
`dotcom-rendering/dist/AppsLightboxImage-importable.web.********************.js`	2.82 kB	0 B
`dotcom-rendering/dist/AudioAtomWrapper-importable.web.********************.js`	3.51 kB	0 B
`dotcom-rendering/dist/AustralianTerritorySwitcher-importable.web.********************.js`	4.6 kB	0 B
`dotcom-rendering/dist/Branding-importable.web.********************.js`	2.23 kB	0 B
`dotcom-rendering/dist/braze-web-sdk-core.web.********************.js`	36.9 kB	0 B
`dotcom-rendering/dist/BrazeMessaging-importable.web.********************.js`	5.28 kB	0 B
`dotcom-rendering/dist/CalloutBlockComponent-importable.web.********************.js`	6.68 kB	0 B
`dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.web.********************.js`	5.99 kB	0 B
`dotcom-rendering/dist/CardCommentCount-importable.web.********************.js`	2.89 kB	0 B
`dotcom-rendering/dist/Carousel-importable.web.********************.js`	7.61 kB	0 B
`dotcom-rendering/dist/CarouselForNewsletters-importable.web.********************.js`	5.38 kB	0 B
`dotcom-rendering/dist/ChartAtom-importable.web.********************.js`	500 B	0 B
`dotcom-rendering/dist/CommentCount-importable.web.********************.js`	3.06 kB	0 B
`dotcom-rendering/dist/DiscussionContainer-importable.web.********************.js`	23.9 kB	0 B
`dotcom-rendering/dist/DiscussionMeta-importable.web.********************.js`	3.67 kB	0 B
`dotcom-rendering/dist/DocumentBlockComponent-importable.web.********************.js`	3.3 kB	0 B
`dotcom-rendering/dist/EmbedBlockComponent-importable.web.********************.js`	3.85 kB	0 B
`dotcom-rendering/dist/EnhancePinnedPost-importable.web.********************.js`	1.95 kB	0 B
`dotcom-rendering/dist/FetchOnwardsData-importable.web.********************.js`	2.5 kB	0 B
`dotcom-rendering/dist/FilterKeyEventsToggle-importable.web.********************.js`	3.31 kB	0 B
`dotcom-rendering/dist/FocusStyles-importable.web.********************.js`	607 B	0 B
`dotcom-rendering/dist/FollowWrapper-importable.web.********************.js`	1.25 kB	0 B
`dotcom-rendering/dist/FooterLabel-importable.web.********************.js`	336 B	0 B
`dotcom-rendering/dist/frameworks.web.********************.js`	20.8 kB	0 B
`dotcom-rendering/dist/GetCricketScoreboard-importable.web.********************.js`	3.48 kB	0 B
`dotcom-rendering/dist/GetMatchNav-importable.web.********************.js`	10.1 kB	0 B
`dotcom-rendering/dist/GetMatchStats-importable.web.********************.js`	613 B	0 B
`dotcom-rendering/dist/GetMatchTabs-importable.web.********************.js`	2.54 kB	0 B
`dotcom-rendering/dist/guardian-braze-components-banner.web.********************.js`	13.4 kB	0 B
`dotcom-rendering/dist/guardian-braze-components-end-of-article.web.********************.js`	9 kB	0 B
`dotcom-rendering/dist/GuideAtomWrapper-importable.web.********************.js`	790 B	0 B
`dotcom-rendering/dist/HeaderTopBar-importable.web.********************.js`	10.8 kB	0 B
`dotcom-rendering/dist/index.web.********************.js`	45.2 kB	+1 B (0%)
`dotcom-rendering/dist/InstagramBlockComponent-importable.web.********************.js`	3.38 kB	0 B
`dotcom-rendering/dist/InteractiveBlockComponent-importable.web.********************.js`	5.92 kB	0 B
`dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.web.********************.js`	3.79 kB	0 B
`dotcom-rendering/dist/InteractiveSupportButton-importable.web.********************.js`	3.83 kB	0 B
`dotcom-rendering/dist/KeyEventsCarousel-importable.web.********************.js`	2.72 kB	0 B
`dotcom-rendering/dist/KnowledgeQuizAtom-importable.web.********************.js`	3.52 kB	0 B
`dotcom-rendering/dist/LatestLinks-importable.web.********************.js`	1.17 kB	0 B
`dotcom-rendering/dist/LightboxHash-importable.web.********************.js`	430 B	0 B
`dotcom-rendering/dist/LightboxJavascript-importable.web.********************.js`	4.64 kB	0 B
`dotcom-rendering/dist/LiveBlogEpic-importable.web.********************.js`	4.79 kB	0 B
`dotcom-rendering/dist/Liveness-importable.web.********************.js`	3.34 kB	0 B
`dotcom-rendering/dist/ManyNewsletterSignUp-importable.web.********************.js`	4.98 kB	0 B
`dotcom-rendering/dist/MapEmbedBlockComponent-importable.web.********************.js`	5.33 kB	0 B
`dotcom-rendering/dist/Metrics-importable.web.********************.js`	2.29 kB	0 B
`dotcom-rendering/dist/MostViewedFooter-importable.web.********************.js`	5.67 kB	0 B
`dotcom-rendering/dist/MostViewedFooterData-importable.web.********************.js`	8.34 kB	0 B
`dotcom-rendering/dist/MostViewedRightWrapper-importable.web.********************.js`	3.73 kB	0 B
`dotcom-rendering/dist/OnwardsUpper-importable.web.********************.js`	4.17 kB	0 B
`dotcom-rendering/dist/PersonalityQuizAtom-importable.web.********************.js`	3.66 kB	0 B
`dotcom-rendering/dist/ProfileAtom-importable.web.********************.js`	547 B	0 B
`dotcom-rendering/dist/ProfileAtomWrapper-importable.web.********************.js`	810 B	0 B
`dotcom-rendering/dist/PulsingDot-importable.web.********************.js`	744 B	0 B
`dotcom-rendering/dist/QandaAtom-importable.web.********************.js`	542 B	0 B
`dotcom-rendering/dist/ReaderRevenueDev-importable.web.********************.js`	466 B	0 B
`dotcom-rendering/dist/readerRevenueDevUtils.web.********************.js`	2.44 kB	0 B
`dotcom-rendering/dist/ReaderRevenueLinks-importable.web.********************.js`	4.92 kB	0 B
`dotcom-rendering/dist/RelativeTime-importable.web.********************.js`	1.92 kB	0 B
`dotcom-rendering/dist/RichLinkComponent-importable.web.********************.js`	6.42 kB	0 B
`dotcom-rendering/dist/SecureSignupIframe-importable.web.********************.js`	4.93 kB	0 B
`dotcom-rendering/dist/SendAMessage-importable.web.********************.js`	4.6 kB	0 B
`dotcom-rendering/dist/SendTargetingParams-importable.web.********************.js`	2.04 kB	0 B
`dotcom-rendering/dist/sentry.web.********************.js`	772 B	0 B
`dotcom-rendering/dist/SetABTests-importable.web.********************.js`	3.37 kB	0 B
`dotcom-rendering/dist/SetAdTargeting-importable.web.********************.js`	481 B	0 B
`dotcom-rendering/dist/shimport.web.********************.js`	2.78 kB	0 B
`dotcom-rendering/dist/ShowHideContainers-importable.web.********************.js`	642 B	0 B
`dotcom-rendering/dist/ShowMore-importable.web.********************.js`	5.59 kB	0 B
`dotcom-rendering/dist/SignInGateMain.web.********************.js`	3.86 kB	0 B
`dotcom-rendering/dist/SignInGateMainCheckoutComplete.web.********************.js`	4.94 kB	0 B
`dotcom-rendering/dist/SignInGateSelector-importable.web.********************.js`	5.55 kB	0 B
`dotcom-rendering/dist/SlotBodyEnd-importable.web.********************.js`	6.37 kB	0 B
`dotcom-rendering/dist/SpotifyBlockComponent-importable.web.********************.js`	5.18 kB	0 B
`dotcom-rendering/dist/StickyBottomBanner-importable.web.********************.js`	5.74 kB	0 B
`dotcom-rendering/dist/SubNav-importable.web.********************.js`	2.36 kB	0 B
`dotcom-rendering/dist/SupportTheG-importable.web.********************.js`	5.05 kB	0 B
`dotcom-rendering/dist/TableOfContents-importable.web.********************.js`	2.82 kB	0 B
`dotcom-rendering/dist/TimelineAtom-importable.web.********************.js`	1.22 kB	0 B
`dotcom-rendering/dist/TweetBlockComponent-importable.web.********************.js`	1.01 kB	0 B
`dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.web.********************.js`	3.39 kB	0 B
`dotcom-rendering/dist/VideoFacebookBlockComponent-importable.web.********************.js`	5.35 kB	0 B
`dotcom-rendering/dist/VineBlockComponent-importable.web.********************.js`	3.24 kB	0 B
`dotcom-rendering/dist/WeatherWrapper-importable.web.********************.js`	5.41 kB	0 B
`dotcom-rendering/dist/YoutubeBlockComponent-importable.web.********************.js`	3.73 kB	0 B

_{compressed-size-action}

.gitignore

mxdvl

🧶

I like it, like, a lot!

Is it blazing fast?

sndrs · 2023-11-23T18:02:13Z

Is it blazing fast?

it's pretty fast yeah. behaviour is an improvement on v1 (only hoisting to workspace level) but there are improvements available once this is merged (pnpm mode, possibly pnp mode, or then pnpm itself). so this is a first step more than the end game

…s/yarn-4

…nto sndrs/yarn-4 # Conflicts: # yarn.lock

github-actions bot added apps-rendering dotcom-rendering labels Nov 13, 2023

sndrs mentioned this pull request Nov 13, 2023

Stop using yarn@1 in DCR #9421

Closed

sndrs linked an issue Nov 13, 2023 that may be closed by this pull request

Stop using yarn@1 in DCR #9421

Closed

sndrs force-pushed the sndrs/yarn-4 branch from d295646 to c34a983 Compare November 13, 2023 18:17

sndrs changed the title ~~yarn 4 WIP~~ WIP spike yarn 4 Nov 14, 2023

sndrs force-pushed the sndrs/yarn-4 branch 2 times, most recently from fd076ae to baf610d Compare November 14, 2023 15:50

sndrs added run_chromatic Runs chromatic when label is applied and removed run_chromatic Runs chromatic when label is applied labels Nov 14, 2023

sndrs force-pushed the sndrs/yarn-4 branch 2 times, most recently from a89d453 to fec19ef Compare November 20, 2023 18:50

sndrs added this to the 👋 Yarn v1 milestone Nov 21, 2023

sndrs force-pushed the sndrs/yarn-4 branch 6 times, most recently from d0d2671 to 47c7e3e Compare November 22, 2023 17:41

sndrs changed the title ~~WIP spike yarn 4~~ Upgrade Yarn to v4 Nov 22, 2023

sndrs self-assigned this Nov 22, 2023

sndrs marked this pull request as ready for review November 22, 2023 18:04

sndrs requested a review from a team as a code owner November 22, 2023 18:04

sndrs added 2 commits November 23, 2023 16:58

upgrade yarn to 4.0.2

13e93c6

fix AR linting errors

6c8028f

sndrs force-pushed the sndrs/yarn-4 branch from 47c7e3e to 6c8028f Compare November 23, 2023 16:58

mxdvl reviewed Nov 23, 2023

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

mxdvl approved these changes Nov 23, 2023

View reviewed changes

sndrs added 6 commits November 24, 2023 10:37

add comment about yarn to gitignore

9eea929

upgrade yarn to 4.0.2

a897f10

fix AR linting errors

b38f632

add comment about yarn to gitignore

b9d46a5

Merge branch 'main' of github.com:guardian/dotcom-rendering into sndr…

d9dfeac

…s/yarn-4

Merge branch 'sndrs/yarn-4' of github.com:guardian/dotcom-rendering i…

2be757f

…nto sndrs/yarn-4 # Conflicts: # yarn.lock

sndrs merged commit 6f357e8 into main Nov 27, 2023
33 checks passed

sndrs deleted the sndrs/yarn-4 branch November 27, 2023 10:46

sndrs mentioned this pull request Nov 27, 2023

Revert "Upgrade Yarn to v4" #9661

Merged

This was referenced Dec 5, 2023

Confirm we're using Corepack in preinstall hook #9791

Merged

Upgrade Yarn to v4, take 2 #9662

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade Yarn to v4 #9466

Upgrade Yarn to v4 #9466

sndrs commented Nov 13, 2023 •

edited

Loading

github-actions bot commented Nov 13, 2023 •

edited

Loading

mxdvl left a comment •

edited

Loading

sndrs commented Nov 23, 2023

Upgrade Yarn to v4 #9466

Upgrade Yarn to v4 #9466

Conversation

sndrs commented Nov 13, 2023 • edited Loading

What does this change?

Why?

Screenshot

github-actions bot commented Nov 13, 2023 • edited Loading

mxdvl left a comment • edited Loading

Choose a reason for hiding this comment

sndrs commented Nov 23, 2023

sndrs commented Nov 13, 2023 •

edited

Loading

github-actions bot commented Nov 13, 2023 •

edited

Loading

mxdvl left a comment •

edited

Loading