Retrieve only matching football competition by tag #27713
Draft
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiAdcock
commented
Jan 10, 2025
| @@ -26,7 +26,7 @@ trait Competitions extends implicits.Football { | |||
| competitions.filter(_.url == path), | |||
| ) | |||
|
|
|||
| def competitionsWithTag(tag: String): Option[Competition] = competitions.find(_.url.endsWith(tag)) | |||
| def competitionsWithTag(tag: String): Option[Competition] = competitions.find(_.url.endsWith(s"/$tag")) | |||
There was a problem hiding this comment.
Maybe we'd prefer to hardcode the football prefix into this check. Happy to discuss.
Suggested change
| def competitionsWithTag(tag: String): Option[Competition] = competitions.find(_.url.endsWith(s"/$tag")) | |
| def competitionsWithTag(tag: String): Option[Competition] = competitions.find(_.url == s"football/$tag") |
JamieB-gu
approved these changes
Jan 14, 2025
|
@SiAdcock is it by purpose that in league selector disappears? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the value of this and can you measure success?
The competition by tag search only compares the tag we are looking for with the end of the competition tag.
If a competition tag ends with the same string as another competition tag, this can lead to an incorrect competition being sent.
Examples of tags in the
competitionslist:(full list)
In the above example, if we passed the tag
"nations-league"to this function, the function would find the competition"/football/women-s-nations-league"before"/football/nations-league"What does this change?
Ensure we are matching everything after
football/in the tag name, rather than the end of the tagScreenshots
Checklist