Delete old commercial API code #27755
Merged
+0
−1,548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prout-bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
Seen-on-ADMIN-PROD
and removed
Pending-on-ADMIN-PROD
labels
|
Seen on ADMIN-PROD (merged by @Jakeii 11 minutes and 21 seconds ago)
|
|
Seen on FRONTS-PROD (merged by @Jakeii 12 minutes and 26 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
The routes were deleted in #27726 we were quite confident that they aren't used any more, but have monitored logs for the last 30 days and they haven't received any requests, so we're deleting the code that drove them.
This includes the CommercialLifecycle (distinct from the DFPAgentLifecycle!) which runs a background job that got data for the travel and jobs endpoints and stored it in S3.
Have tested on CODE and everything we need to work still works.