-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store layouts in s3 #328
Open
dblatcher
wants to merge
29
commits into
main
Choose a base branch
from
dblatcher/store-layouts-in-s3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
store layouts in s3 #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
How to test
Run locally, with the "developer" permissions set in .env.local (see main readme for setup):
USER_PERMISSIONS={"[email protected]": 0}
go to http://localhost:4200/layouts to see the main UI - you should be able to create and edit layouts
shut down the app, change the user permission level to :
USER_PERMISSIONS={"[email protected]": 3}
run the app again and you go to go to http://localhost:4200/layouts - you should have read-only access
How can we measure success?
This moves towards having the arrangement on the /email-newsletters page controlled from the newsletters tool, rather than requiring PR's in the DCR repo.
subsequent PRs:
Have we considered potential risks?
The new pages are not in the nav bar yet, so users are unlikely to find them. We can modify this branch so it won't result in the new /layouts UI pages being made live with the current config - this can be done by editing apps/newsletters-api/src/register-ui-server.ts
It should be safe to have the newsletters API publish the /layouts routes - the data will be 'empty' unless we populate them in the UI
Images
Accessibility