Merge pull request #958 from guardian/ph-20231118-1557-supporter-plus…

…-fix correct bug in supporter+ charge override for annuals
guardian · Nov 20, 2023 · 7ae4c3c · 7ae4c3c
2 parents 11e8372 + 3d3e8b4
commit 7ae4c3c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lambda/src/main/scala/pricemigrationengine/migrations/SupporterPlus2023V1V2Migration.scala b/lambda/src/main/scala/pricemigrationengine/migrations/SupporterPlus2023V1V2Migration.scala
@@ -264,14 +264,14 @@ object SupporterPlus2023V1V2Migration {
     val chargeOverrides = for {
       currency <- item.currency
       price <- currencyToNewPrice("Annual", currency).toOption
-      estimatedPrice <- item.estimatedNewPrice
+      oldPrice <- item.oldPrice
     } yield {
-      if (estimatedPrice > price) {
+      if (oldPrice > price) {
         List(
           ChargeOverride(
             productRatePlanChargeId = "8a12892d85fc6df4018602451322287f", // Annual Contribution
             billingPeriod = "Annual",
-            price = estimatedPrice - price
+            price = oldPrice - price
           )
         )
       } else {

diff --git a/lambda/src/test/scala/pricemigrationengine/handlers/AmendmentHandlerTest.scala b/lambda/src/test/scala/pricemigrationengine/handlers/AmendmentHandlerTest.scala
@@ -789,8 +789,8 @@ class AmendmentHandlerTest extends munit.FunSuite {
         processingStage = NotificationSendDateWrittenToSalesforce,
         startDate = Some(LocalDate.of(2024, 6, 28)),
         currency = Some("GBP"),
-        oldPrice = Some(BigDecimal(120)),
-        estimatedNewPrice = Some(BigDecimal(120)),
+        oldPrice = Some(BigDecimal(120)), // Here we simulate the subscription having a £25 contribution
+        estimatedNewPrice = Some(BigDecimal(95)), // correct rate plan price for annual GBP
         billingPeriod = Some("Annual")
       )