Skip to content

Commit

Permalink
Merge pull request #933 from guardian/ph-20230926-0838-amedment-check…
Browse files Browse the repository at this point in the history
…-part1-5

refactoring: rename failure
  • Loading branch information
shtukas authored Sep 26, 2023
2 parents b89c764 + 8421492 commit bcb9c7a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ object AmendmentHandler extends CohortHandler {
val result = ExpiringSubscriptionResult(item.subscriptionName)
CohortTable.update(CohortItem.fromExpiringSubscriptionResult(result)).as(result)
}
case _: IncompatibleAmendmentHistory => {
case _: IncompatibleAmendmentHistoryFailure => {
// See the preambule of the ZuoraSubscriptionAmendment case class for context about
// IncompatibleAmendmentHistory
// Note: At the moment we only have one CancelledAmendmentResult, it would be great one day
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ case class ZuoraRenewalFailure(reason: String) extends Failure
case class AmendmentDataFailure(reason: String) extends Failure
case class CancelledSubscriptionFailure(reason: String) extends Failure
case class ExpiringSubscriptionFailure(reason: String) extends Failure
case class IncompatibleAmendmentHistory(reason: String) extends Failure
case class IncompatibleAmendmentHistoryFailure(reason: String) extends Failure

case class SalesforcePriceRiseWriteFailure(reason: String) extends Failure
case class SalesforceClientFailure(reason: String) extends Failure
Expand Down

0 comments on commit bcb9c7a

Please sign in to comment.