Enforce the Migration suffix naming convention #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shtukas
force-pushed
the
ph-20231002-1601-refactoring
branch
2 times, most recently
from
e398947
to
4cc2dde
Compare
shtukas
force-pushed
the
ph-20231002-1601-refactoring
branch
from
af15b80
to
2355c62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second of two preliminary refactorings as part of background work for the DigiSubs migration (first PR is here: #936)
In this case we are now enforcing the convention that Migration specific utility files/models should be suffixed with "Migration" (like we do with handlers that are all suffixed "Handler"). Will will avoid conflicting naming with elements of the
MigrationTypetrait