-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Cloudquery to 5.19 and enable Sync Summary #1023
Conversation
This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days |
This PR was closed because it has been stalled for 3 days with no activity. |
This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days |
@@ -3,7 +3,7 @@ import { Versions } from './versions'; | |||
|
|||
export const Images = { | |||
cloudquery: ContainerImage.fromRegistry( | |||
`ghcr.io/guardian/service-catalogue/cloudquery:stable`, | |||
`ghcr.io/guardian/service-catalogue/cloudquery:sha-2d6c95ee216c4fa9723aa3d0f8dc4e2a4636080b`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this change needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remnants from trying to test this branch in CODE, it can be reverted.
As is this PR doesn't currently work, in the original CloudQuery PR they suggest adding a send_sync_summary
field to the destination plugin config but that doesn't seem to be correct
This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days |
This PR was closed because it has been stalled for 3 days with no activity. |
What does this change?
Bumps Cloudquery to 5.19 and enable Sync Summary for all jobs.
Why?
Cloudquery 5.19 just released the ability to enable sync summaries. This feature sends a summary of the sync to the destination plugin in the form of a
cloudquery_sync_summary
table.We can possibly simplify our Cloudquery job by removing the initial postgres step. This also lets us generate a reliability report for our Cloudquery tasks.
How has it been verified?
Deployed to CODE.