Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Cloudquery to 5.19 and enable Sync Summary #1023

Closed
wants to merge 3 commits into from
Closed

Conversation

AshCorr
Copy link
Member

@AshCorr AshCorr commented May 22, 2024

What does this change?

Bumps Cloudquery to 5.19 and enable Sync Summary for all jobs.

Why?

Cloudquery 5.19 just released the ability to enable sync summaries. This feature sends a summary of the sync to the destination plugin in the form of a cloudquery_sync_summary table.

We can possibly simplify our Cloudquery job by removing the initial postgres step. This also lets us generate a reliability report for our Cloudquery tasks.

How has it been verified?

Deployed to CODE.

@AshCorr AshCorr requested review from a team as code owners May 22, 2024 09:32
Copy link

This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days

@github-actions github-actions bot added the Stale label Jun 24, 2024
Copy link

github-actions bot commented Jul 1, 2024

This PR was closed because it has been stalled for 3 days with no activity.

@github-actions github-actions bot closed this Jul 1, 2024
@AshCorr AshCorr reopened this Jul 1, 2024
@github-actions github-actions bot removed the Stale label Jul 2, 2024
Copy link

github-actions bot commented Aug 5, 2024

This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days

@github-actions github-actions bot added the Stale label Aug 5, 2024
@@ -3,7 +3,7 @@ import { Versions } from './versions';

export const Images = {
cloudquery: ContainerImage.fromRegistry(
`ghcr.io/guardian/service-catalogue/cloudquery:stable`,
`ghcr.io/guardian/service-catalogue/cloudquery:sha-2d6c95ee216c4fa9723aa3d0f8dc4e2a4636080b`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remnants from trying to test this branch in CODE, it can be reverted.

As is this PR doesn't currently work, in the original CloudQuery PR they suggest adding a send_sync_summary field to the destination plugin config but that doesn't seem to be correct

@github-actions github-actions bot removed the Stale label Aug 8, 2024
Copy link

github-actions bot commented Sep 9, 2024

This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days

@github-actions github-actions bot added the Stale label Sep 9, 2024
Copy link

This PR was closed because it has been stalled for 3 days with no activity.

@github-actions github-actions bot closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants