chore: Suppress AWS Inspector FSBP findings. #1339
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ): boolean { | ||
| // Suppress AWS Inspector findings | ||
| // These currently have a cost impact associated to them and has limited language support. | ||
| // With InfoSec at the moment to decide what we do with this control: |
There was a problem hiding this comment.
It feels a little risky to enumerate security controls we're planning to ignore in a public repo. Is there a way to filter these findings in a more private way? Could @guardian/devx-security suppress them centrally?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Temporarily hide AWS Inspector findings from the FSBP dashboard.
Why?
As far as I'm aware the guidance is to ignore this finding for now as per https://chat.google.com/room/AAAAag0I08g/5caKQThOs8Q/FHanFOG9rnw as it has a cost associated and is pending feedback from InfoSec on what to do about it.
I also want to see my accounts FSBP Dashboard drop to 0 vulnerabilities too 😅
How has it been verified?
Don't have credentials to test this locally unfortunately, have included tests however.